Patchwork [v2,2/2] pci: Differentiate ACS controllable from enabled

mail settings
Submitter Alex Williamson
Date June 7, 2013, 4:34 p.m.
Message ID <20130607163447.7733.70375.stgit@bling.home>
Download mbox | patch
Permalink /patch/249758/
State Superseded
Headers show


Alex Williamson - June 7, 2013, 4:34 p.m.
We currently misinterpret that in order for an ACS feature to be
enabled it must be set in the control field.  In reality, this means
that the feature is not only enabled, but controllable.  Many of the
ACS capability bits are not required if the device behaves by default
in the way specified when both the capability and control bit are set
and does not support or allow the alternate mode.  We therefore need
to check the capabilities and mask out flags that are enabled but not
controllable.  Egress control seems to be the only flag which is
purely optional.

Signed-off-by: Alex Williamson <>
 drivers/pci/pci.c |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to
More majordomo info at


diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 457ae51..8b8504c 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2357,12 +2357,20 @@  void pci_enable_acs(struct pci_dev *dev)
 static bool pci_acs_flags_enabled(struct pci_dev *pdev, u16 acs_flags)
 	int pos;
-	u16 ctrl;
+	u16 cap, ctrl;
 	pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ACS);
 	if (!pos)
 		return false;
+	/*
+	 * Except for egress control, capabilities are either required
+	 * or only required if controllable.  Features missing from the
+	 * capability field can therefore be assumed as hard-wired enabled.
+	 */
+	pci_read_config_word(pdev, pos + PCI_ACS_CAP, &cap);
+	acs_flags &= (cap | PCI_ACS_EC);
 	pci_read_config_word(pdev, pos + PCI_ACS_CTRL, &ctrl);
 	return (ctrl & acs_flags) == acs_flags;
@@ -2412,9 +2420,6 @@  bool pci_acs_enabled(struct pci_dev *pdev, u16 acs_flags)
 		if (!pdev->multifunction)
-		acs_flags &= (PCI_ACS_RR | PCI_ACS_CR |
-			      PCI_ACS_EC | PCI_ACS_DT);
 		return pci_acs_flags_enabled(pdev, acs_flags);