From patchwork Fri Jun 7 13:00:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 249713 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 922F72C0040 for ; Fri, 7 Jun 2013 23:07:13 +1000 (EST) Received: from localhost ([::1]:59260 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkwNr-0005Ln-Ik for incoming@patchwork.ozlabs.org; Fri, 07 Jun 2013 09:07:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkwHc-0004n6-4L for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:00:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkwHX-0000Eo-O1 for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:00:44 -0400 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:45314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkwHX-0000Eb-Hc for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:00:39 -0400 Received: from blackfin.pond.sub.org (p5B32AF77.dip0.t-ipconnect.de [91.50.175.119]) by oxygen.pond.sub.org (Postfix) with ESMTPA id C1BE9A62D7; Fri, 7 Jun 2013 15:00:37 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B77B8200B8; Fri, 7 Jun 2013 15:00:36 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Fri, 7 Jun 2013 15:00:35 +0200 Message-Id: <1370610036-10577-6-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1370610036-10577-1-git-send-email-armbru@redhat.com> References: <1370610036-10577-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: aliguori@us.ibm.com, lersek@redhat.com Subject: [Qemu-devel] [PATCH v2 5/6] smbios: Fix -smbios type=0, release=... for big endian hosts X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Classic endianness bug due to careless dirty coding: assuming reading a byte from an int variable gets the least significant byte. Signed-off-by: Markus Armbruster --- hw/i386/smbios.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index 322f0a0..6431dd4 100644 --- a/hw/i386/smbios.c +++ b/hw/i386/smbios.c @@ -127,6 +127,7 @@ void smbios_add_field(int type, int offset, const void *data, size_t len) static void smbios_build_type_0_fields(const char *t) { char buf[1024]; + unsigned char major, minor; if (get_param_value(buf, sizeof(buf), "vendor", t)) smbios_add_field(0, offsetof(struct smbios_type_0, vendor_str), @@ -139,8 +140,7 @@ static void smbios_build_type_0_fields(const char *t) bios_release_date_str), buf, strlen(buf) + 1); if (get_param_value(buf, sizeof(buf), "release", t)) { - int major, minor; - sscanf(buf, "%d.%d", &major, &minor); + sscanf(buf, "%hhu.%hhu", &major, &minor); smbios_add_field(0, offsetof(struct smbios_type_0, system_bios_major_release), &major, 1);