Patchwork [v2,6/6] smbios: Check R in -smbios type=0, release=R parses okay

login
register
mail settings
Submitter Markus Armbruster
Date June 7, 2013, 1 p.m.
Message ID <1370610036-10577-7-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/249711/
State New
Headers show

Comments

Markus Armbruster - June 7, 2013, 1 p.m.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/i386/smbios.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Patch

diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index 6431dd4..e708cb8 100644
--- a/hw/i386/smbios.c
+++ b/hw/i386/smbios.c
@@ -140,7 +140,10 @@  static void smbios_build_type_0_fields(const char *t)
                                      bios_release_date_str),
                          buf, strlen(buf) + 1);
     if (get_param_value(buf, sizeof(buf), "release", t)) {
-        sscanf(buf, "%hhu.%hhu", &major, &minor);
+        if (sscanf(buf, "%hhu.%hhu", &major, &minor) != 2) {
+            error_report("Invalid release");
+            exit(1);
+        }
         smbios_add_field(0, offsetof(struct smbios_type_0,
                                      system_bios_major_release),
                          &major, 1);