Patchwork powerpc/83xx: Update ranges in gianfar node to match other dts

login
register
mail settings
Submitter Kumar Gala
Date March 24, 2009, 1:35 p.m.
Message ID <1237901745-27418-1-git-send-email-galak@kernel.crashing.org>
Download mbox | patch
Permalink /patch/24970/
State Accepted, archived
Delegated to: Kumar Gala
Headers show

Comments

Kumar Gala - March 24, 2009, 1:35 p.m.
The gianfar node @ 25000 was missing its ranges prop for the mdio bus
and provided an explicit ranges property on gianfar@24000 to match
all other .dts

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 arch/powerpc/boot/dts/mpc8313erdb.dts |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Scott Wood - March 24, 2009, 4 p.m.
On Tue, Mar 24, 2009 at 08:35:45AM -0500, Kumar Gala wrote:
> The gianfar node @ 25000 was missing its ranges prop for the mdio bus
> and provided an explicit ranges property on gianfar@24000 to match
> all other .dts
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  arch/powerpc/boot/dts/mpc8313erdb.dts |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/boot/dts/mpc8313erdb.dts
> index 3ebf7ec..20a0fa8 100644
> --- a/arch/powerpc/boot/dts/mpc8313erdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
> @@ -180,7 +180,7 @@
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			sleep = <&pmc 0x20000000>;
> -			ranges;
> +			ranges = <0x0 0x24000 0x1000>;
>  
>  			cell-index = <0>;
>  			device_type = "network";

You need to fix the reg property of the child node to match this change
in ranges.  Was this boot-tested (or is it a case of Linux's device tree
parsing being excessively tolerant of broken trees)?

-Scott
Kumar Gala - March 24, 2009, 5:42 p.m.
On Mar 24, 2009, at 11:00 AM, Scott Wood wrote:

> On Tue, Mar 24, 2009 at 08:35:45AM -0500, Kumar Gala wrote:
>> The gianfar node @ 25000 was missing its ranges prop for the mdio bus
>> and provided an explicit ranges property on gianfar@24000 to match
>> all other .dts
>>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>> arch/powerpc/boot/dts/mpc8313erdb.dts |    3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/ 
>> boot/dts/mpc8313erdb.dts
>> index 3ebf7ec..20a0fa8 100644
>> --- a/arch/powerpc/boot/dts/mpc8313erdb.dts
>> +++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
>> @@ -180,7 +180,7 @@
>> 			#address-cells = <1>;
>> 			#size-cells = <1>;
>> 			sleep = <&pmc 0x20000000>;
>> -			ranges;
>> +			ranges = <0x0 0x24000 0x1000>;
>>
>> 			cell-index = <0>;
>> 			device_type = "network";
>
> You need to fix the reg property of the child node to match this  
> change
> in ranges.  Was this boot-tested (or is it a case of Linux's device  
> tree
> parsing being excessively tolerant of broken trees)?
>
I didn't boot test.. Anton pointed this issue out as well.

- k

Patch

diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/boot/dts/mpc8313erdb.dts
index 3ebf7ec..20a0fa8 100644
--- a/arch/powerpc/boot/dts/mpc8313erdb.dts
+++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
@@ -180,7 +180,7 @@ 
 			#address-cells = <1>;
 			#size-cells = <1>;
 			sleep = <&pmc 0x20000000>;
-			ranges;
+			ranges = <0x0 0x24000 0x1000>;
 
 			cell-index = <0>;
 			device_type = "network";
@@ -221,6 +221,7 @@ 
 			model = "eTSEC";
 			compatible = "gianfar";
 			reg = <0x25000 0x1000>;
+			ranges = <0x0 0x25000 0x1000>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupts = <34 0x8 33 0x8 32 0x8>;
 			interrupt-parent = <&ipic>;