From patchwork Fri Jun 7 12:38:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 249695 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 4737B2C007E for ; Fri, 7 Jun 2013 22:39:11 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; q=dns; s=default; b=uZymVoC3YAVak+B4 964PxQv/ijhLUVrxSQxeQCrSJSrrR7df6VfHfQEz5UXbIfkgbGelu2c+0AT8UV/B IpLQpLpAI24GjqiYsOUn6EHXr/X3pzNK9lqDbKO6+1OXPCBmil6I8IeZ4dugi/Xr EqanRz9BwUKX5zR9DFP5NkOAsh0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=default; bh=Mxkc0vz5gDKSIgOI6rcfDV f6AV8=; b=oN4J4DAYiE3vF0la1zfY+Ty4tgIwskDo+O3rz95VF+XNncnlB0LEmy MtxTRiyT+bKmMYjRLLapLarm7g/Yb5HSx8YCompySYeHIgCdn0gsnO79vhfOkPqY wfnwWc391C9sXts516VN992Xa7mY7gb0hl9uOSSPZfvEJKKb+0S5g= Received: (qmail 28550 invoked by alias); 7 Jun 2013 12:39:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28532 invoked by uid 89); 7 Jun 2013 12:39:04 -0000 X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, TW_GD, TW_TM autolearn=ham version=3.3.1 Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 07 Jun 2013 12:38:37 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 5D81A144; Fri, 7 Jun 2013 14:38:34 +0200 (CEST) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DpBzrXeGGu54; Fri, 7 Jun 2013 14:38:32 +0200 (CEST) Received: from lokon.CeBiTec.Uni-Bielefeld.DE (lokon.CeBiTec.Uni-Bielefeld.DE [129.70.161.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id CA116142; Fri, 7 Jun 2013 14:38:31 +0200 (CEST) Received: (from ro@localhost) by lokon.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id r57CcUrn003732; Fri, 7 Jun 2013 14:38:30 +0200 (MEST) From: Rainer Orth To: Andreas Schwab Cc: Dehao Chen , Cary Coutant , Mike Stump , Eric Botcazou , GCC Patches Subject: Re: [PATCH] Fix incorrect discriminator assignment. References: <2793520.f28ygdVO2W@polaris> <31BD98EB-D529-43F1-8FD5-101387129806@mrs.kithrup.com> <874ndjfaio.fsf@hase.home> Date: Fri, 07 Jun 2013 14:38:30 +0200 In-Reply-To: <874ndjfaio.fsf@hase.home> (Andreas Schwab's message of "Fri, 31 May 2013 17:13:03 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (usg-unix-v) MIME-Version: 1.0 X-Virus-Found: No Andreas Schwab writes: > Rainer Orth writes: > >> Indeed, and I see -ansi -pedantic-errors -gdwarf-2 -O0 used for the test >> on both x86_64-unknown-linux-gnu and i386-pc-solaris2.10 (if I augment >> the target clause). > > DEFAULT_CFLAGS is set by many *.exp files. dwarf2.exp will not > overwrite an existing definition, so using anthing different from "-ansi > -pedantic-errors" will not work. Right, I noticed this myself. Most likely just another one of the many instances of mindless copy-and-paste programming in our testsuite ;-( I've now applied the following patch to fix this, after testing on x86_64-unknown-linux-gnu. Btw., I've started implementing a dwarf2_debug_line effective-target keyword for the testsuite. Rainer 2013-06-07 Rainer Orth * gcc.dg/debug/dwarf2/discriminator.c: Fix wording. Revert to dg-options. diff --git a/gcc/testsuite/gcc.dg/debug/dwarf2/discriminator.c b/gcc/testsuite/gcc.dg/debug/dwarf2/discriminator.c --- a/gcc/testsuite/gcc.dg/debug/dwarf2/discriminator.c +++ b/gcc/testsuite/gcc.dg/debug/dwarf2/discriminator.c @@ -1,7 +1,7 @@ /* HAVE_AS_DWARF2_DEBUG_LINE macro needs to be defined to pass the unittest. - However, there dg cannot defin it as, so we restrict the target to linux. */ + However, dg cannot access it, so we restrict the target to linux. */ /* { dg-do compile { target *-*-linux-gnu } } */ -/* { dg-additional-options "-O0" } */ +/* { dg-options "-O0 -gdwarf-2" } */ /* { dg-final { scan-assembler "loc \[0-9] 11 \[0-9]( is_stmt \[0-9])?\n" } } */ /* { dg-final { scan-assembler "loc \[0-9] 11 \[0-9]( is_stmt \[0-9])? discriminator 2\n" } } */ /* { dg-final { scan-assembler "loc \[0-9] 11 \[0-9]( is_stmt \[0-9])? discriminator 1\n" } } */