From patchwork Fri Jun 7 01:00:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 249574 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qc0-x23a.google.com (mail-qc0-x23a.google.com [IPv6:2607:f8b0:400d:c01::23a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 15E1C2C0098 for ; Fri, 7 Jun 2013 11:01:02 +1000 (EST) Received: by mail-qc0-f186.google.com with SMTP id d1sf938067qcz.23 for ; Thu, 06 Jun 2013 18:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-beenthere:x-auditid:from:to:cc:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=dSgtTGBQdSQssGv7PLQlGcmNout3CnoDrV/4CtkbXpw=; b=RW7tkBwO3iNIa3Ve8S0ckU+TYAAp4zocyEPJuP0/zbrIcralEg3B8HEkS+cR9o5TiK NyX4Ym1/DgfT/N1Cdtd6rqj0O2XH1PxRCJiaTGwx3lY1PtL6JwaaOVXzwz2NCdWzIngm +5Mc7uit6tvY4CmnnDIgixzT7Q5gyOn2n9EKRVMdK/G+s2k72RyJXJSYn4cKjcCRpM0Z nfhPIknocRWH1QMowd0L8e8fRWt+6tVwg0lovyvIUDJKbiWDqLlVpcMdUnszLgbCLSNu YQUBipqaagBl5JuinepcnZ0bzKonStkFPISdqFfmhkknl5lLGOzwIckiQYGSzScsnSHX yQtQ== X-Received: by 10.50.112.105 with SMTP id ip9mr89861igb.1.1370566857494; Thu, 06 Jun 2013 18:00:57 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.119.103 with SMTP id kt7ls125825igb.41.gmail; Thu, 06 Jun 2013 18:00:56 -0700 (PDT) X-Received: by 10.66.166.102 with SMTP id zf6mr34957pab.47.1370566856495; Thu, 06 Jun 2013 18:00:56 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id sr2si4556859pbc.2.2013.06.06.18.00.56 for ; Thu, 06 Jun 2013 18:00:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MO000JMH05JRO90@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 07 Jun 2013 10:00:55 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 6A.2A.17404.7C031B15; Fri, 07 Jun 2013 10:00:55 +0900 (KST) X-AuditID: cbfee68d-b7f096d0000043fc-19-51b130c73ef0 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 0F.09.21068.7C031B15; Fri, 07 Jun 2013 10:00:55 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MO0001Q405IXX30@mmp1.samsung.com>; Fri, 07 Jun 2013 10:00:55 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' , 'Andy Shevchenko' Subject: [rtc-linux] [PATCH V3] rtc: rtc-pcf2123: replace strict_strtoul() with kstrtoul() Date: Fri, 07 Jun 2013 10:00:54 +0900 Message-id: <000001ce631a$769f1640$63dd42c0$@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5jGkB/3TuJY7MRTY62toTFRtOCUA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t8zY93jBhsDDQ495bNYcvEqu8Wc9WvY LF5OOMxocXnhJVaLy7vmsFns7+xgdGDz2DnrLrvHnokn2TxOzPjN4tG3ZRWjx/R5P5k8Pm+S C2CL4rJJSc3JLEst0rdL4MpoX7WAreAnd8WD1sVsDYwPOLsYOTkkBEwk7v+6yQZhi0lcuLce yObiEBJYxihxb0s7C0xR39cZLBCJRYwSRxpWgnUICfxilLjzQQDEZhNQk/jy5TB7FyMHh4iA vkRbiwZIPbPAPkaJc6e+M4LEhQX8JD43x4KUswioSkxdPJURxOYVsJQ48X0tM4QtKPFj8j2w vcwCWhLrdx5ngrDlJTavecsMcY+CxI6zr8F6RQT0JOae2csKUSMise/FO0aQvRICt9gldv3Y wQyxTEDi2+RDLCA3SAjISmw6ADVHUuLgihssExjFZiFZPQvJ6llIVs9CsmIBI8sqRtHUguSC 4qT0IkO94sTc4tK8dL3k/NxNjJBo7N3BePuA9SHGZKD1E5mlRJPzgdGcVxJvaGxmZGFqYmps ZG5pRpqwkjivWot1oJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQZGha9dR8QbpTXEskzP5Sy3 OLRU/cIyk5K91gKMasdnRq/KNIz/LnowPqmsZn7ZkjLWrgf+bzprTtvaTxd8en074zbbRWc2 X9UTmN9zOXvXqdmaO++nJqd/zLk+1+tczR7uR5+2H6zccFnw/rFH129tb1j6p/OBxr69bAdl F2QEODs19cx8Z30mSomlOCPRUIu5qDgRAPaYOh/cAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGKsWRmVeSWpSXmKPExsVy+t9jAd3jBhsDDY7c4LJYcvEqu8Wc9WvY LF5OOMxocXnhJVaLy7vmsFns7+xgdGDz2DnrLrvHnokn2TxOzPjN4tG3ZRWjx/R5P5k8Pm+S C2CLamC0yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXLzAG6 Q0mhLDGnFCgUkFhcrKRvh2lCaIibrgVMY4Sub0gQXI+RARpIWMeY0b5qAVvBT+6KB62L2RoY H3B2MXJySAiYSPR9ncECYYtJXLi3nq2LkYtDSGARo8SRhpVsIAkhgV+MEnc+CIDYbAJqEl++ HGbvYuTgEBHQl2hr0QCpZxbYxyhx7tR3RpC4sICfxOfmWJByFgFViamLpzKC2LwClhInvq9l hrAFJX5Mvge2l1lAS2L9zuNMELa8xOY1b5kh7lGQ2HH2NViviICexNwze1khakQk9r14xziB UWAWklGzkIyahWTULCQtCxhZVjGKphYkFxQnpeca6RUn5haX5qXrJefnbmIEx/oz6R2Mqxos DjEKcDAq8fD+WLUhUIg1say4MvcQowQHs5II7ymNjYFCvCmJlVWpRfnxRaU5qcWHGJOBPp3I LCWanA9MQ3kl8YbGJmZGlkZmFkYm5uakCSuJ8x5stQ4UEkhPLEnNTk0tSC2C2cLEwSnVwFgy bZ6i1HX1d1NNjp79oTL1hMuK1anVJt1OV6+3fGv2WxX4fv88hw33F5x9frTCUvH0gqV+5xO8 bk8vaL4crGhmveigyguf9Sx33ZgV61u6px5jusziclaVlYdTcPdi37rMwvS3XrtTKgv67y9e Va67iJ9L8L7/e14l4dWhBx+7VXYZV9a8e67EUpyRaKjFXFScCAB1zoztOQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko The usage of strict_strtoul() is not preferred, because strict_strtoul() is obsolete. Thus, kstrtoul() should be used. Signed-off-by: Jingoo Han Reviewed-by: Andy Shevchenko --- Changes since v2: - Split to two sequential checks. - Added Andy Shevchenko's Reviewed-by. Changes since v1: - Used return code from kstrtoul(). drivers/rtc/rtc-pcf2123.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index b2a78a0..1725b50 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -94,8 +94,9 @@ static ssize_t pcf2123_show(struct device *dev, struct device_attribute *attr, r = container_of(attr, struct pcf2123_sysfs_reg, attr); - if (strict_strtoul(r->name, 16, ®)) - return -EINVAL; + ret = kstrtoul(r->name, 16, ®); + if (ret) + return ret; txbuf[0] = PCF2123_READ | reg; ret = spi_write_then_read(spi, txbuf, 1, rxbuf, 1); @@ -117,9 +118,13 @@ static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr, r = container_of(attr, struct pcf2123_sysfs_reg, attr); - if (strict_strtoul(r->name, 16, ®) - || strict_strtoul(buffer, 10, &val)) - return -EINVAL; + ret = kstrtoul(r->name, 16, ®); + if (ret) + return ret; + + ret = kstrtoul(buffer, 10, &val); + if (ret) + return ret; txbuf[0] = PCF2123_WRITE | reg; txbuf[1] = val;