Patchwork [U-Boot,2/2] phy: smsc: LAN8710/8720 are not Gbit PHYs

login
register
mail settings
Submitter Fabio Estevam
Date June 7, 2013, 12:04 a.m.
Message ID <1370563459-30270-2-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/249559/
State Accepted
Delegated to: Joe Hershberger
Headers show

Comments

Fabio Estevam - June 7, 2013, 12:04 a.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.

Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/net/phy/smsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Fabio Estevam - July 12, 2013, 2:45 a.m.
Hi Joe,

On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.
>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Any comments?
Joe Hershberger - July 12, 2013, 4:57 a.m.
On Thu, Jul 11, 2013 at 9:45 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Joe,
>
> On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.
>>
>> Cc: Joe Hershberger <joe.hershberger@ni.com>
>> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Any comments?


Seems pretty reasonable.  I'll pick it up for next release.

-Joe
Joe Hershberger - July 12, 2013, 5 a.m.
On Thu, Jul 11, 2013 at 11:57 PM, Joe Hershberger
<joe.hershberger@gmail.com> wrote:
> On Thu, Jul 11, 2013 at 9:45 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> Hi Joe,
>>
>> On Thu, Jun 6, 2013 at 9:04 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>>
>>> LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.
>>>
>>> Cc: Joe Hershberger <joe.hershberger@ni.com>
>>> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Any comments?
>
>
> Seems pretty reasonable.  I'll pick it up for next release.

On second thought, it's delegated in patchwork to Stefano and it's
marked rejected.  Why is that Stefano?

-Joe
Fabio Estevam - July 12, 2013, 5:06 a.m.
On Fri, Jul 12, 2013 at 2:00 AM, Joe Hershberger
<joe.hershberger@gmail.com> wrote:

> On second thought, it's delegated in patchwork to Stefano and it's
> marked rejected.  Why is that Stefano?

Ok, I think I understand the reason. I asked him to reject the 1/2
patch of the series (it was a mx28evk related patch).

This one (2/2) is fine.

Sorry for the confusion.
Joe Hershberger - July 12, 2013, 5:37 a.m.
On Fri, Jul 12, 2013 at 12:06 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Fri, Jul 12, 2013 at 2:00 AM, Joe Hershberger
> <joe.hershberger@gmail.com> wrote:
>
>> On second thought, it's delegated in patchwork to Stefano and it's
>> marked rejected.  Why is that Stefano?
>
> Ok, I think I understand the reason. I asked him to reject the 1/2
> patch of the series (it was a mx28evk related patch).
>
> This one (2/2) is fine.
>
> Sorry for the confusion.

OK.  That sounds fine.

-Joe
Stefano Babic - July 12, 2013, 6:58 a.m.
On 12/07/2013 07:06, Fabio Estevam wrote:
> On Fri, Jul 12, 2013 at 2:00 AM, Joe Hershberger
> <joe.hershberger@gmail.com> wrote:
> 
>> On second thought, it's delegated in patchwork to Stefano and it's
>> marked rejected.  Why is that Stefano?
> 
> Ok, I think I understand the reason. I asked him to reject the 1/2
> patch of the series (it was a mx28evk related patch).
> 
> This one (2/2) is fine.
> 
> Sorry for the confusion.

Yes, I confirm this - I rejected on Fabio's request.

Regards,
Stefano
Joe Hershberger - Aug. 19, 2013, 5:41 p.m.
On Thu, Jun 6, 2013 at 7:04 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.
>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied, Thanks!
-Joe

Patch

diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index 6dee8eb..0c658f4 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -76,7 +76,7 @@  static struct phy_driver lan8710_driver = {
 	.name = "SMSC LAN8710/LAN8720",
 	.uid = 0x0007c0f0,
 	.mask = 0xffff0,
-	.features = PHY_GBIT_FEATURES,
+	.features = PHY_BASIC_FEATURES,
 	.config = &genphy_config_aneg,
 	.startup = &smsc_startup,
 	.shutdown = &genphy_shutdown,