Patchwork [04/14] lua-msgpack-native: fix github tarball to use commit id

login
register
mail settings
Submitter Spenser Gilliland
Date June 6, 2013, 4:47 p.m.
Message ID <1370537249-15682-4-git-send-email-spenser@gillilanding.com>
Download mbox | patch
Permalink /patch/249493/
State Accepted
Headers show

Comments

Spenser Gilliland - June 6, 2013, 4:47 p.m.
Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
---
 package/lua-msgpack-native/lua-msgpack-native.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Yann E. MORIN - June 6, 2013, 5:42 p.m.
Spenser, All,

On 2013-06-06 11:47 -0500, Spenser Gilliland spake thusly:
> Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
> ---
>  package/lua-msgpack-native/lua-msgpack-native.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/lua-msgpack-native/lua-msgpack-native.mk b/package/lua-msgpack-native/lua-msgpack-native.mk
> index 97ce83c..b9ef21c 100644
> --- a/package/lua-msgpack-native/lua-msgpack-native.mk
> +++ b/package/lua-msgpack-native/lua-msgpack-native.mk
> @@ -4,7 +4,7 @@
>  #
>  #############################################################
>  LUA_MSGPACK_NATIVE_VERSION = g41cce91
> -LUA_MSGPACK_NATIVE_SITE = http://github.com/kengonakajima/lua-msgpack-native/tarball/master
> +LUA_MSGPACK_NATIVE_SITE = http://github.com/kengonakajima/lua-msgpack-native/tarball/${LUA_MSGPACK_NATIVE_VERSION)

$ make
package/lua-msgpack-native/lua-msgpack-native.mk:8: *** unterminated
variable reference.  Stop.
make: *** [all] Error 2

That's because you are using an opening curly-brace, but a closing
parenthesis in: ${LUA_MSGPACK_NATIVE_VERSION)

Regards,
Yann E. MORIN.
Spenser Gilliland - June 6, 2013, 6:12 p.m.
On Thu, Jun 6, 2013 at 12:42 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Spenser, All,
>
> On 2013-06-06 11:47 -0500, Spenser Gilliland spake thusly:
>> Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
>> ---
>>  package/lua-msgpack-native/lua-msgpack-native.mk |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/lua-msgpack-native/lua-msgpack-native.mk b/package/lua-msgpack-native/lua-msgpack-native.mk
>> index 97ce83c..b9ef21c 100644
>> --- a/package/lua-msgpack-native/lua-msgpack-native.mk
>> +++ b/package/lua-msgpack-native/lua-msgpack-native.mk
>> @@ -4,7 +4,7 @@
>>  #
>>  #############################################################
>>  LUA_MSGPACK_NATIVE_VERSION = g41cce91
>> -LUA_MSGPACK_NATIVE_SITE = http://github.com/kengonakajima/lua-msgpack-native/tarball/master
>> +LUA_MSGPACK_NATIVE_SITE = http://github.com/kengonakajima/lua-msgpack-native/tarball/${LUA_MSGPACK_NATIVE_VERSION)
>
> $ make
> package/lua-msgpack-native/lua-msgpack-native.mk:8: *** unterminated
> variable reference.  Stop.
> make: *** [all] Error 2
>
> That's because you are using an opening curly-brace, but a closing
> parenthesis in: ${LUA_MSGPACK_NATIVE_VERSION)
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'

Good catch!

Spenser

--
Spenser Gilliland
Computer Engineer
Doctoral Candidate

Patch

diff --git a/package/lua-msgpack-native/lua-msgpack-native.mk b/package/lua-msgpack-native/lua-msgpack-native.mk
index 97ce83c..b9ef21c 100644
--- a/package/lua-msgpack-native/lua-msgpack-native.mk
+++ b/package/lua-msgpack-native/lua-msgpack-native.mk
@@ -4,7 +4,7 @@ 
 #
 #############################################################
 LUA_MSGPACK_NATIVE_VERSION = g41cce91
-LUA_MSGPACK_NATIVE_SITE = http://github.com/kengonakajima/lua-msgpack-native/tarball/master
+LUA_MSGPACK_NATIVE_SITE = http://github.com/kengonakajima/lua-msgpack-native/tarball/${LUA_MSGPACK_NATIVE_VERSION)
 LUA_MSGPACK_NATIVE_DEPENDENCIES = lua
 LUA_MSGPACK_NATIVE_LICENSE = Apache-2.0
 LUA_MSGPACK_NATIVE_LICENSE_FILES = LICENSE.txt