Patchwork [U-Boot,v2,2/7] ac14xx: cleanup comments in the board support

login
register
mail settings
Submitter Gerhard Sittig
Date June 5, 2013, 12:51 p.m.
Message ID <1370436671-12422-3-git-send-email-gsi@denx.de>
Download mbox | patch
Permalink /patch/249028/
State Accepted
Delegated to: Wolfgang Denk
Headers show

Comments

Gerhard Sittig - June 5, 2013, 12:51 p.m.
fix typos, minor rephrasing, remove obsolete notes and TODO items

Signed-off-by: Gerhard Sittig <gsi@denx.de>
---
 board/ifm/ac14xx/ac14xx.c |   10 ++--------
 include/configs/ac14xx.h  |    5 ++---
 2 files changed, 4 insertions(+), 11 deletions(-)
Wolfgang Denk - June 24, 2013, 8:26 p.m.
Dear Gerhard Sittig,

In message <1370436671-12422-3-git-send-email-gsi@denx.de> you wrote:
> fix typos, minor rephrasing, remove obsolete notes and TODO items
> 
> Signed-off-by: Gerhard Sittig <gsi@denx.de>
> ---
>  board/ifm/ac14xx/ac14xx.c |   10 ++--------
>  include/configs/ac14xx.h  |    5 ++---
>  2 files changed, 4 insertions(+), 11 deletions(-)

Applied to u-boot-mpc5xxx, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/board/ifm/ac14xx/ac14xx.c b/board/ifm/ac14xx/ac14xx.c
index f200b45..d45b7b2 100644
--- a/board/ifm/ac14xx/ac14xx.c
+++ b/board/ifm/ac14xx/ac14xx.c
@@ -37,7 +37,7 @@  static void gpio_configure(void)
 
 	/*
 	 * out_be32(&gpioregs->gpdir, 0xC2293020);
-	 * workaround for a hardware affect: configure direction in pieces,
+	 * workaround for a hardware effect: configure direction in pieces,
 	 * setting all outputs at once drops the reset line too low and
 	 * makes us lose the MII connection (breaks ethernet for us)
 	 */
@@ -330,8 +330,7 @@  int misc_init_r(void)
 	gpio_configure();
 
 	/*
-	 * check the GPIO keyboard,
-	 * enforced start of the recovery when
+	 * enforce the start of the recovery system when
 	 * - the appropriate keys were pressed
 	 * - a previous installation was aborted or has failed
 	 * - "some" external software told us to
@@ -339,13 +338,8 @@  int misc_init_r(void)
 	want_recovery = 0;
 	keys = gpio_querykbd();
 	printf("GPIO keyboard status [0x%08X]\n", keys);
-	/* XXX insist in the _exact_ combination? */
 	if ((keys & GPIOKEY_BITS_RECOVERY) == GPIOKEY_BITS_RECOVERY) {
 		printf("GPIO keyboard requested RECOVERY\n");
-		/* XXX TODO
-		 * refine the logic to detect the first keypress, and
-		 * wait to recheck IF it was the recovery combination?
-		 */
 		want_recovery = 1;
 	}
 	s = getenv("install_in_progress");
diff --git a/include/configs/ac14xx.h b/include/configs/ac14xx.h
index 7cb10fb..5dbcba2 100644
--- a/include/configs/ac14xx.h
+++ b/include/configs/ac14xx.h
@@ -72,7 +72,7 @@ 
 #define CONFIG_SYS_MAX_RAM_SIZE		0x20000000
 
 /*
- * DDR Controller Configuration XXX TODO
+ * DDR Controller Configuration
  *
  * SYS_CFG:
  *	[31:31]	MDDRC Soft Reset:	Diabled
@@ -265,7 +265,6 @@ 
 
 /*
  * CS related parameters
- * TODO document these
  */
 /* CS0 Flash */
 #define CONFIG_SYS_CS0_CFG		0x00031110
@@ -506,7 +505,7 @@ 
 
 #define CONFIG_BOOTDELAY	2	/* -1 disables auto-boot */
 
-/* XXX TODO need to specify the builtin environment */
+/* the builtin environment and standard greeting */
 #define CONFIG_PREBOOT	"echo;"	\
 	"echo Type \\\"run flash_nfs\\\" to mount root filesystem over NFS;" \
 	"echo"