Patchwork data: klog.json: remove duplicated patterns

login
register
mail settings
Submitter Alex Hung
Date June 5, 2013, 9:52 a.m.
Message ID <1370425977-5516-1-git-send-email-alex.hung@canonical.com>
Download mbox | patch
Permalink /patch/248989/
State Accepted
Headers show

Comments

Alex Hung - June 5, 2013, 9:52 a.m.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 data/klog.json |   72 --------------------------------------------------------
 1 file changed, 72 deletions(-)
Colin King - June 5, 2013, 1 p.m.
On 05/06/13 10:52, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  data/klog.json |   72 --------------------------------------------------------
>  1 file changed, 72 deletions(-)
> 
> diff --git a/data/klog.json b/data/klog.json
> index b581d1b..388018c 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -3722,78 +3722,6 @@
>     "label": "KlogHpWmiBadEventStatus"
>    },
>    {
> -   "compare_mode": "string",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_THERMAL",
> -   "pattern": "Failed to create sysfs link 'thermal_cooling'",
> -   "advice": "sysfs_create_link() failed to create the thermal 'thermal_cooling' sysfs entry.",
> -   "label": "KlogAcpiThermalThermalCoolingSysfs"
> -  },
> -  {
> -   "compare_mode": "string",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_THERMAL",
> -   "pattern": "Failed to create sysfs link 'device'",
> -   "advice": "sysfs_create_link() failed to create the thermal 'device' sysfs entry.",
> -   "label": "KlogAcpiThemalDeviceSysfs"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
> -   "pattern": "EC.*input buffer is not empty, aborting transaction",
> -   "advice": "The ACPI Embedded Controller (EC) driver attempted to perform a read or write transaction but had to abort because the EC was still busy and the input buffer was not emptied within 500ms.  Normally this indicates an EC firmware fault.  One can try increasing the delay using the acpi.ec_delay kernel parameter or writing to /sys/module/acpi/parameters/ec_delay - however this generally does not help much of the EC firmware is buggy.",
> -   "label": "KlogAcpiEcInputBufferIsNotEmpty"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_CRITICAL",
> -   "tag": "FWTS_TAG_ACPI",
> -   "pattern": "pnp.*can't evaluate _CRS: 12311",
> -   "advice": "The _CRS object could not be evaluated because an invalid resource type has been returned. This can lead to misconfigured PNP hardware and may render a system unbootable.",
> -   "label": "KlogPnpCrsInvalidResourceType"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_CRITICAL",
> -   "tag": "FWTS_TAG_ACPI",
> -   "pattern": "pnp.*can't evaluate _CRS:",
> -   "advice": "The _CRS object could not be evaluated, the error code is an ACPI error return code (see include/acpi/acexecp.h in the linux source, this is composed of bottom 12 bits of an error number and upper 4 bits of an AE_CODE_* code. Typically, _CRS evaluation errors can lead to misconfigured PNP hardware and may render a system unbootable.",
> -   "label": "KlogPnpCrsCannotEvaluate"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_WMI",
> -   "pattern": "dell_wmi:.*Received unknown WMI event",
> -   "advice": "The Dell WMI driver has received an unknown WMI event. The driver should handle this new event or the firmware is reporting an incorrect and unknown event.",
> -   "label": "KlogDellWmiReceivedUnknownWMIEvent"
> -  },
> -  {
> -   "compare_mode": "string",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_WMI",
> -   "pattern": "dell_wmi:.*bad event status 0x",
> -   "advice": "The Dell WMI driver has received a bad event status. This should be investigated further.",
> -   "label": "KlogDellWmiBadEventStatus"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_WMI",
> -   "pattern": "asus_wmi:.*Unknown key.*pressed",
> -   "advice": "The ASUS WMI driver has received an unknown key event. The driver should handle this new key event or the firmware is reporting an incorrect and unknown event.",
> -   "label": "KlogAsusWmiUnknownKeypressed"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_WMI",
> -   "pattern": "hp_wmi:.*bad event status 0x",
> -   "advice": "The HP WMI driver has received a bad event status. This should be investigated further.",
> -   "label": "KlogHpWmiBadEventStatus"
> -  },
> -  {
>     "compare_mode": "regex",
>     "log_level": "LOG_LEVEL_HIGH",
>     "tag": "FWTS_TAG_WMI",
> 
I guess I yanked and pasted these in by mistake in vim. Thanks for
spotting this duplication Alex.

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu - June 10, 2013, 6:47 a.m.
On 06/05/2013 05:52 PM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   data/klog.json |   72 --------------------------------------------------------
>   1 file changed, 72 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index b581d1b..388018c 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -3722,78 +3722,6 @@
>      "label": "KlogHpWmiBadEventStatus"
>     },
>     {
> -   "compare_mode": "string",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_THERMAL",
> -   "pattern": "Failed to create sysfs link 'thermal_cooling'",
> -   "advice": "sysfs_create_link() failed to create the thermal 'thermal_cooling' sysfs entry.",
> -   "label": "KlogAcpiThermalThermalCoolingSysfs"
> -  },
> -  {
> -   "compare_mode": "string",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_ACPI_THERMAL",
> -   "pattern": "Failed to create sysfs link 'device'",
> -   "advice": "sysfs_create_link() failed to create the thermal 'device' sysfs entry.",
> -   "label": "KlogAcpiThemalDeviceSysfs"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
> -   "pattern": "EC.*input buffer is not empty, aborting transaction",
> -   "advice": "The ACPI Embedded Controller (EC) driver attempted to perform a read or write transaction but had to abort because the EC was still busy and the input buffer was not emptied within 500ms.  Normally this indicates an EC firmware fault.  One can try increasing the delay using the acpi.ec_delay kernel parameter or writing to /sys/module/acpi/parameters/ec_delay - however this generally does not help much of the EC firmware is buggy.",
> -   "label": "KlogAcpiEcInputBufferIsNotEmpty"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_CRITICAL",
> -   "tag": "FWTS_TAG_ACPI",
> -   "pattern": "pnp.*can't evaluate _CRS: 12311",
> -   "advice": "The _CRS object could not be evaluated because an invalid resource type has been returned. This can lead to misconfigured PNP hardware and may render a system unbootable.",
> -   "label": "KlogPnpCrsInvalidResourceType"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_CRITICAL",
> -   "tag": "FWTS_TAG_ACPI",
> -   "pattern": "pnp.*can't evaluate _CRS:",
> -   "advice": "The _CRS object could not be evaluated, the error code is an ACPI error return code (see include/acpi/acexecp.h in the linux source, this is composed of bottom 12 bits of an error number and upper 4 bits of an AE_CODE_* code. Typically, _CRS evaluation errors can lead to misconfigured PNP hardware and may render a system unbootable.",
> -   "label": "KlogPnpCrsCannotEvaluate"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_WMI",
> -   "pattern": "dell_wmi:.*Received unknown WMI event",
> -   "advice": "The Dell WMI driver has received an unknown WMI event. The driver should handle this new event or the firmware is reporting an incorrect and unknown event.",
> -   "label": "KlogDellWmiReceivedUnknownWMIEvent"
> -  },
> -  {
> -   "compare_mode": "string",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_WMI",
> -   "pattern": "dell_wmi:.*bad event status 0x",
> -   "advice": "The Dell WMI driver has received a bad event status. This should be investigated further.",
> -   "label": "KlogDellWmiBadEventStatus"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_WMI",
> -   "pattern": "asus_wmi:.*Unknown key.*pressed",
> -   "advice": "The ASUS WMI driver has received an unknown key event. The driver should handle this new key event or the firmware is reporting an incorrect and unknown event.",
> -   "label": "KlogAsusWmiUnknownKeypressed"
> -  },
> -  {
> -   "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_WMI",
> -   "pattern": "hp_wmi:.*bad event status 0x",
> -   "advice": "The HP WMI driver has received a bad event status. This should be investigated further.",
> -   "label": "KlogHpWmiBadEventStatus"
> -  },
> -  {
>      "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_HIGH",
>      "tag": "FWTS_TAG_WMI",
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index b581d1b..388018c 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -3722,78 +3722,6 @@ 
    "label": "KlogHpWmiBadEventStatus"
   },
   {
-   "compare_mode": "string",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_ACPI_THERMAL",
-   "pattern": "Failed to create sysfs link 'thermal_cooling'",
-   "advice": "sysfs_create_link() failed to create the thermal 'thermal_cooling' sysfs entry.",
-   "label": "KlogAcpiThermalThermalCoolingSysfs"
-  },
-  {
-   "compare_mode": "string",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_ACPI_THERMAL",
-   "pattern": "Failed to create sysfs link 'device'",
-   "advice": "sysfs_create_link() failed to create the thermal 'device' sysfs entry.",
-   "label": "KlogAcpiThemalDeviceSysfs"
-  },
-  {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
-   "pattern": "EC.*input buffer is not empty, aborting transaction",
-   "advice": "The ACPI Embedded Controller (EC) driver attempted to perform a read or write transaction but had to abort because the EC was still busy and the input buffer was not emptied within 500ms.  Normally this indicates an EC firmware fault.  One can try increasing the delay using the acpi.ec_delay kernel parameter or writing to /sys/module/acpi/parameters/ec_delay - however this generally does not help much of the EC firmware is buggy.",
-   "label": "KlogAcpiEcInputBufferIsNotEmpty"
-  },
-  {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_CRITICAL",
-   "tag": "FWTS_TAG_ACPI",
-   "pattern": "pnp.*can't evaluate _CRS: 12311",
-   "advice": "The _CRS object could not be evaluated because an invalid resource type has been returned. This can lead to misconfigured PNP hardware and may render a system unbootable.",
-   "label": "KlogPnpCrsInvalidResourceType"
-  },
-  {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_CRITICAL",
-   "tag": "FWTS_TAG_ACPI",
-   "pattern": "pnp.*can't evaluate _CRS:",
-   "advice": "The _CRS object could not be evaluated, the error code is an ACPI error return code (see include/acpi/acexecp.h in the linux source, this is composed of bottom 12 bits of an error number and upper 4 bits of an AE_CODE_* code. Typically, _CRS evaluation errors can lead to misconfigured PNP hardware and may render a system unbootable.",
-   "label": "KlogPnpCrsCannotEvaluate"
-  },
-  {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_WMI",
-   "pattern": "dell_wmi:.*Received unknown WMI event",
-   "advice": "The Dell WMI driver has received an unknown WMI event. The driver should handle this new event or the firmware is reporting an incorrect and unknown event.",
-   "label": "KlogDellWmiReceivedUnknownWMIEvent"
-  },
-  {
-   "compare_mode": "string",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_WMI",
-   "pattern": "dell_wmi:.*bad event status 0x",
-   "advice": "The Dell WMI driver has received a bad event status. This should be investigated further.",
-   "label": "KlogDellWmiBadEventStatus"
-  },
-  {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_WMI",
-   "pattern": "asus_wmi:.*Unknown key.*pressed",
-   "advice": "The ASUS WMI driver has received an unknown key event. The driver should handle this new key event or the firmware is reporting an incorrect and unknown event.",
-   "label": "KlogAsusWmiUnknownKeypressed"
-  },
-  {
-   "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_WMI",
-   "pattern": "hp_wmi:.*bad event status 0x",
-   "advice": "The HP WMI driver has received a bad event status. This should be investigated further.",
-   "label": "KlogHpWmiBadEventStatus"
-  },
-  {
    "compare_mode": "regex",
    "log_level": "LOG_LEVEL_HIGH",
    "tag": "FWTS_TAG_WMI",