Patchwork data: klog.json: remove almost duplicated EC message

login
register
mail settings
Submitter Colin King
Date June 5, 2013, 9:38 a.m.
Message ID <1370425100-32687-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/248985/
State Rejected
Headers show

Comments

Colin King - June 5, 2013, 9:38 a.m.
From: Colin Ian King <colin.king@canonical.com>

It appers we have this message almost identically duplicated in
the klog.json database, except for an if/of spelling difference.
Remove the duplicate entry. Spotted by Alex Hung.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 8 --------
 1 file changed, 8 deletions(-)
Alex Hung - June 5, 2013, 9:55 a.m.
On 06/05/2013 05:38 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> It appers we have this message almost identically duplicated in
> the klog.json database, except for an if/of spelling difference.
> Remove the duplicate entry. Spotted by Alex Hung.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index b581d1b..9727894 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -3739,14 +3739,6 @@
>     },
>     {
>      "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> -   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
> -   "pattern": "EC.*input buffer is not empty, aborting transaction",
> -   "advice": "The ACPI Embedded Controller (EC) driver attempted to perform a read or write transaction but had to abort because the EC was still busy and the input buffer was not emptied within 500ms.  Normally this indicates an EC firmware fault.  One can try increasing the delay using the acpi.ec_delay kernel parameter or writing to /sys/module/acpi/parameters/ec_delay - however this generally does not help much of the EC firmware is buggy.",
> -   "label": "KlogAcpiEcInputBufferIsNotEmpty"
> -  },
> -  {
> -   "compare_mode": "regex",
>      "log_level": "LOG_LEVEL_CRITICAL",
>      "tag": "FWTS_TAG_ACPI",
>      "pattern": "pnp.*can't evaluate _CRS: 12311",
>
Hi Colin,

I also found some other duplicated one and sent a patch. :)

Patch

diff --git a/data/klog.json b/data/klog.json
index b581d1b..9727894 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -3739,14 +3739,6 @@ 
   },
   {
    "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
-   "tag": "FWTS_TAG_EMBEDDED_CONTROLLER",
-   "pattern": "EC.*input buffer is not empty, aborting transaction",
-   "advice": "The ACPI Embedded Controller (EC) driver attempted to perform a read or write transaction but had to abort because the EC was still busy and the input buffer was not emptied within 500ms.  Normally this indicates an EC firmware fault.  One can try increasing the delay using the acpi.ec_delay kernel parameter or writing to /sys/module/acpi/parameters/ec_delay - however this generally does not help much of the EC firmware is buggy.",
-   "label": "KlogAcpiEcInputBufferIsNotEmpty"
-  },
-  {
-   "compare_mode": "regex",
    "log_level": "LOG_LEVEL_CRITICAL",
    "tag": "FWTS_TAG_ACPI",
    "pattern": "pnp.*can't evaluate _CRS: 12311",