| Message ID | ec732a1673510a786e5333b00730b8226e792357.1370356776.git.joe@perches.com |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c index 2cf7408..90bd111 100644 --- a/drivers/mtd/onenand/samsung.c +++ b/drivers/mtd/onenand/samsung.c @@ -895,8 +895,8 @@ static int s3c_onenand_probe(struct platform_device *pdev) r = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!r) { dev_err(&pdev->dev, "no memory resource defined\n"); - return -ENOENT; - goto ahb_resource_failed; + err = -ENOENT; + goto resource_failed; } onenand->base_res = request_mem_region(r->start, resource_size(r),
The code uses return foo; goto err_type; when instead the form should have been ret = foo; goto err_type; Here this causes a useful kfree to be skipped. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/mtd/onenand/samsung.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)