From patchwork Mon Jun 3 20:44:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arturo Borrero X-Patchwork-Id: 248413 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A26A32C009D for ; Tue, 4 Jun 2013 06:44:57 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757732Ab3FCUoz (ORCPT ); Mon, 3 Jun 2013 16:44:55 -0400 Received: from smtp3.cica.es ([150.214.5.190]:42343 "EHLO smtp.cica.es" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757604Ab3FCUoz (ORCPT ); Mon, 3 Jun 2013 16:44:55 -0400 Received: from localhost (unknown [127.0.0.1]) by smtp.cica.es (Postfix) with ESMTP id 6D6C251ED8B; Mon, 3 Jun 2013 20:44:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at cica.es Received: from smtp.cica.es ([127.0.0.1]) by localhost (mail.cica.es [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ymnm+omA4RXv; Mon, 3 Jun 2013 22:44:54 +0200 (CEST) Received: from nfdev.cica.es (nfdev.cica.es [IPv6:2a00:9ac0:c1ca:31::220]) by smtp.cica.es (Postfix) with ESMTP id 47A5551ED7D; Mon, 3 Jun 2013 22:44:54 +0200 (CEST) Subject: [libnftables PATCH 2/5] rule: fix snprintf return value To: netfilter-devel@vger.kernel.org From: Arturo Borrero Cc: pablo@netfilter.org Date: Mon, 03 Jun 2013 22:44:52 +0200 Message-ID: <20130603204452.27713.79515.stgit@nfdev.cica.es> In-Reply-To: <20130603204451.27713.51887.stgit@nfdev.cica.es> References: <20130603204451.27713.51887.stgit@nfdev.cica.es> User-Agent: StGit/0.15 MIME-Version: 1.0 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org This cause some chained snprintf to fail. Signed-off-by: Arturo Borrero Gonzalez --- src/rule.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/src/rule.c b/src/rule.c index f0208d9..a91d21d 100644 --- a/src/rule.c +++ b/src/rule.c @@ -676,7 +676,7 @@ static int nft_rule_snprintf_xml(char *buf, size_t size, struct nft_rule *r, ret = snprintf(buf+offset, len, ""); SNPRINTF_BUFFER_SIZE(ret, size, len, offset); - return ret; + return offset; } static int nft_rule_snprintf_default(char *buf, size_t size, struct nft_rule *r, @@ -699,7 +699,7 @@ static int nft_rule_snprintf_default(char *buf, size_t size, struct nft_rule *r, SNPRINTF_BUFFER_SIZE(ret, size, len, offset); } - return ret; + return offset; } int nft_rule_snprintf(char *buf, size_t size, struct nft_rule *r,