Patchwork configure.ac: fix automake warnings reported with recent automake updates:

login
register
mail settings
Submitter Colin King
Date June 3, 2013, 9:29 a.m.
Message ID <1370251765-25433-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/248215/
State Rejected
Headers show

Comments

Colin King - June 3, 2013, 9:29 a.m.
From: Colin Ian King <colin.king@canonical.com>

automake: warnings are treated as errors
/usr/share/automake-1.13/am/ltlibrary.am: warning: 'libfwtsacpica.la': linking libtool libraries using a non-POSIX
/usr/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in 'configure.ac'

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)
Colin King - June 3, 2013, 10:32 a.m.
On 03/06/13 10:29, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> automake: warnings are treated as errors
> /usr/share/automake-1.13/am/ltlibrary.am: warning: 'libfwtsacpica.la': linking libtool libraries using a non-POSIX
> /usr/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in 'configure.ac'
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 77d44bf..477c008 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2,6 +2,7 @@
>            AM_INIT_AUTOMAKE([-Wall -Werror foreign])
>  	  AC_CANONICAL_HOST
>  	  AC_CONFIG_MACRO_DIR([m4])
> +	  AM_PROG_AR
>            AC_PROG_CC
>  	  AC_PROG_LEX
>  	  AC_PROG_YACC
> 
NACK on my patch. Keng-Yu's is better.

Colin
Keng-Yu Lin - June 3, 2013, 10:36 a.m.
On Mon, Jun 3, 2013 at 5:29 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> automake: warnings are treated as errors
> /usr/share/automake-1.13/am/ltlibrary.am: warning: 'libfwtsacpica.la': linking libtool libraries using a non-POSIX
> /usr/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in 'configure.ac'
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac b/configure.ac
> index 77d44bf..477c008 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2,6 +2,7 @@
>            AM_INIT_AUTOMAKE([-Wall -Werror foreign])
>           AC_CANONICAL_HOST
>           AC_CONFIG_MACRO_DIR([m4])
> +         AM_PROG_AR
>            AC_PROG_CC
>           AC_PROG_LEX
>           AC_PROG_YACC
> --
> 1.8.1.2
>

I happened to make a (almost) duplicate patch as this one.
However this patch can make fwts built well on raring and quantal, so

Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/configure.ac b/configure.ac
index 77d44bf..477c008 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,6 +2,7 @@ 
           AM_INIT_AUTOMAKE([-Wall -Werror foreign])
 	  AC_CANONICAL_HOST
 	  AC_CONFIG_MACRO_DIR([m4])
+	  AM_PROG_AR
           AC_PROG_CC
 	  AC_PROG_LEX
 	  AC_PROG_YACC