| Message ID | 1370014677-4626-1-git-send-email-nicolas.dichtel@6wind.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Fri, 2013-05-31 at 17:37 +0200, Nicolas Dichtel wrote: > This stat is not relevant in IPv6, there is no checksum in IPv6 header. > Just leave a comment to explain the hole. > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > --- Acked-by: Eric Dumazet <edumazet@google.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Fri, 31 May 2013 10:11:36 -0700 > On Fri, 2013-05-31 at 17:37 +0200, Nicolas Dichtel wrote: >> This stat is not relevant in IPv6, there is no checksum in IPv6 header. >> Just leave a comment to explain the hole. >> >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> >> --- > > Acked-by: Eric Dumazet <edumazet@google.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv6/proc.c b/net/ipv6/proc.c index f3c1ff4..51c3285 100644 --- a/net/ipv6/proc.c +++ b/net/ipv6/proc.c @@ -90,7 +90,7 @@ static const struct snmp_mib snmp6_ipstats_list[] = { SNMP_MIB_ITEM("Ip6OutMcastOctets", IPSTATS_MIB_OUTMCASTOCTETS), SNMP_MIB_ITEM("Ip6InBcastOctets", IPSTATS_MIB_INBCASTOCTETS), SNMP_MIB_ITEM("Ip6OutBcastOctets", IPSTATS_MIB_OUTBCASTOCTETS), - SNMP_MIB_ITEM("InCsumErrors", IPSTATS_MIB_CSUMERRORS), + /* IPSTATS_MIB_CSUMERRORS is not relevant in IPv6 (no checksum) */ SNMP_MIB_SENTINEL };
This stat is not relevant in IPv6, there is no checksum in IPv6 header. Just leave a comment to explain the hole. Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> --- v3: remove the stat, not relevant in IPv6 remove spotted-by because it was only for the 'wrong' stat name (missing prefix 'Ip6') v2: add Spotted-by line net/ipv6/proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)