Message ID | 51A87BB6.7060207@efe-gmbh.de |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
On 05/31/2013 12:30 PM, Jens Renner (EFE) wrote: > s/allocal/allocate/ > > Signed-off-by: Jens Renner <renner@efe-gmbh.de> > --- > drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > index aa14d8a..aaadf7e 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c > +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > @@ -877,7 +877,7 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) > > bus = mdiobus_alloc(); > if (!bus) { > - dev_err(dev, "Failed to allocal mdiobus\n"); > + dev_err(dev, "Failed to allocate mdiobus\n"); > return -ENOMEM; > } Acked-by: Michal Simek <monstr@monstr.eu> Thanks, Michal
From: Michal Simek <monstr@monstr.eu> Date: Fri, 31 May 2013 12:36:34 +0200 > On 05/31/2013 12:30 PM, Jens Renner (EFE) wrote: >> s/allocal/allocate/ >> >> Signed-off-by: Jens Renner <renner@efe-gmbh.de> >> --- >> drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c >> index aa14d8a..aaadf7e 100644 >> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c >> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c >> @@ -877,7 +877,7 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) >> >> bus = mdiobus_alloc(); >> if (!bus) { >> - dev_err(dev, "Failed to allocal mdiobus\n"); >> + dev_err(dev, "Failed to allocate mdiobus\n"); >> return -ENOMEM; >> } > > Acked-by: Michal Simek <monstr@monstr.eu> You're acking a patch that is corrupted by the submitter's email client and won't even apply :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/01/2013 01:36 AM, David Miller wrote: > From: Michal Simek <monstr@monstr.eu> > Date: Fri, 31 May 2013 12:36:34 +0200 > >> On 05/31/2013 12:30 PM, Jens Renner (EFE) wrote: >>> s/allocal/allocate/ >>> >>> Signed-off-by: Jens Renner <renner@efe-gmbh.de> >>> --- >>> drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c >>> index aa14d8a..aaadf7e 100644 >>> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c >>> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c >>> @@ -877,7 +877,7 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) >>> >>> bus = mdiobus_alloc(); >>> if (!bus) { >>> - dev_err(dev, "Failed to allocal mdiobus\n"); >>> + dev_err(dev, "Failed to allocate mdiobus\n"); >>> return -ENOMEM; >>> } >> >> Acked-by: Michal Simek <monstr@monstr.eu> > > You're acking a patch that is corrupted by the submitter's email client > and won't even apply :-) :-) He has sent another email regarding to phy handling and I have applied it, resolved conflicts on the top of my emaclite changes and I thought that it was caused by my changes not because of corrupted patch. That's why I have also tested it. For this particular case, I didn't try to apply it just wanted to let you know that I agree with this change because it fixes my typo. Thanks, Michal
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index aa14d8a..aaadf7e 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -877,7 +877,7 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) bus = mdiobus_alloc(); if (!bus) { - dev_err(dev, "Failed to allocal mdiobus\n"); + dev_err(dev, "Failed to allocate mdiobus\n"); return -ENOMEM; } -- To unsubscribe from this list: send the line "unsubscribe netdev" in
s/allocal/allocate/ Signed-off-by: Jens Renner <renner@efe-gmbh.de> --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html