From patchwork Fri May 31 00:11:09 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dehao Chen X-Patchwork-Id: 247818 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id AE5ED2C008F for ; Fri, 31 May 2013 10:11:23 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=Ftw8T2wW8GMI14x7Ni 3mc5dL11UC3A11d97wHIpXReY48nSS+BLkF2fSCK43ut34/mNT6mZ7T4w0ilVGVI VSnVgDi/AqBcq5sV0yV70JgfzbcW2Z5M4mOprEzWMm7iQE69o0A3fp3RBg/r9tlk JyLhw5tlpmjkb9FPTSM+Vf//g= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=HDlmitzbN5Uj/u1KZ4WUwWCK 51s=; b=hgiKq1sHb5yYVrQCdyMJopZOxA3tkUztYovcH1bBmae3G9sftil/gJei uMYp39QbfD5OwM5alpz4+dXR/4FxXMJ8UIznypLKqTLQtvqpX4KRzlMKajIuUTlc MGN40STDDy/yUqnhBMlDKILbla7NqSu/V9G4E1uISMM6c896JCw= Received: (qmail 21464 invoked by alias); 31 May 2013 00:11:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 21453 invoked by uid 89); 31 May 2013 00:11:15 -0000 X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ee0-f44.google.com (HELO mail-ee0-f44.google.com) (74.125.83.44) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 31 May 2013 00:11:11 +0000 Received: by mail-ee0-f44.google.com with SMTP id b57so51214eek.31 for ; Thu, 30 May 2013 17:11:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=09eqezd1D1pVEhTj6AYNFNPJZtvJ/u2yLGRTndDXJ4E=; b=DT47MD2RgnPYtnJB2L39aNv0rtokGUoo7LnjAEckRQpguMPr+U5mflNjGFLoqcphOC 3te27ertQPPkCq7WN3mltcqiWX5z/HLeMAtm9BLoIIqNY3egrnf8yCrsrKTdMKs2hKsl QIJLC01+fOBO8JwY7GacKL2wBE4VA6E81D32gGeRs/nTpcGIYIsOI1Ef/IRwZiQVIIl6 TKDR4mV30/dvaSrBfyNk40RKlfhL5WYh7iiuqMF4W116jem6yZDaS4clzTh71NYByFEs Tgf6YUJS67752zyJLHIN0F2CH01KKvEBV4La7R3Hz103v4d2rX+ojOBoEO38xsIwksWH PIrw== MIME-Version: 1.0 X-Received: by 10.14.209.5 with SMTP id r5mr11530508eeo.112.1369959069301; Thu, 30 May 2013 17:11:09 -0700 (PDT) Received: by 10.14.134.70 with HTTP; Thu, 30 May 2013 17:11:09 -0700 (PDT) In-Reply-To: References: Date: Thu, 30 May 2013 17:11:09 -0700 Message-ID: Subject: Re: [GOOGLE] More strict checking for call args From: Dehao Chen To: Xinliang David Li Cc: GCC Patches X-Gm-Message-State: ALoCoQk6REyDy0ZeJ1+NRIEQuUhGQt5tHEuRLLEktxiLpmd0YBRFGn3lp43AB3JZKuzjwkqQ9nDEF/gnZw9I0mNfGGOyCn13f+yPGKyWiC7FnFh2tejOL50ejS/7fSgHwM/tXOSvWTstZE5bSjXfkk1wFEN15JVcB+7Aikaut0dXWu3LrjA4VMxOt/bKd6KZhmCcO4dqLjvx Yes, patch updated: Testing on-going. Dehao On Thu, May 30, 2013 at 4:10 PM, Xinliang David Li wrote: > On Thu, May 30, 2013 at 3:47 PM, Dehao Chen wrote: >> This patch makes more strict check of call args to make sure the >> number of args match. >> >> Bootstrapped and passed regression tests. >> >> OK for google branches? >> >> Thanks, >> Dehao >> >> Index: gcc/gimple-low.c >> =================================================================== >> --- gcc/gimple-low.c (revision 199414) >> +++ gcc/gimple-low.c (working copy) >> @@ -254,9 +254,13 @@ gimple_check_call_args (gimple stmt, tree fndecl) >> && !fold_convertible_p (DECL_ARG_TYPE (p), arg))) >> return false; >> } >> + if (p != NULL) >> + return false; >> } >> else if (parms) >> { >> + if (list_length (parms) - nargs != 1) >> + return false; > > This does not seem to be correct for vararg functions. > > David > > >> for (i = 0, p = parms; i < nargs; i++, p = TREE_CHAIN (p)) >> { >> tree arg; Index: gimple-low.c =================================================================== --- gimple-low.c (revision 199414) +++ gimple-low.c (working copy) @@ -254,6 +254,8 @@ && !fold_convertible_p (DECL_ARG_TYPE (p), arg))) return false; } + if (p != NULL) + return false; } else if (parms) {