From patchwork Thu May 30 20:02:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cesar Philippidis X-Patchwork-Id: 247694 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 7493E2C008F for ; Fri, 31 May 2013 06:02:43 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; q= dns; s=default; b=bh8eDUv6Tzcq755ypsbAEQWsHjVXkzzOQCXnljtNG12XM6 BNsIIVYlOwJ2L3WHfoiSErP4DVytYCRhT4BN334nD198tseWq4UaivMkLMDMnxYG pvKLh0C4nRmdC0lMvWKjnqDvf1RLae695crM5pSMCqGjlLvbDO/28UMdMFwiY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; s= default; bh=W0NYwsFyTetYgbhp9eWBN5N3cFU=; b=IYXiJUPN+BpHSGi+rq1D p7lQ9X4n7UR4GhDeWx9Qndm7cPRs541Obdbc2QdIzm9aRH7CcEZ4uvdmwttC7Bt+ ljyptlBhIAtpsdP3oYykQsjj8nFHtFJIpRD3FC37xbH8suLED6/vPGoo40NXOv8r NG6F2rIMdrXyJKn9KCDdV2E= Received: (qmail 1157 invoked by alias); 30 May 2013 20:02:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 1145 invoked by uid 89); 30 May 2013 20:02:35 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 30 May 2013 20:02:35 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Ui93R-0001BK-Nd from Cesar_Philippidis@mentor.com for gcc-patches@gcc.gnu.org; Thu, 30 May 2013 13:02:33 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 30 May 2013 13:02:33 -0700 Received: from mbp17.localdomain (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Thu, 30 May 2013 13:02:33 -0700 Message-ID: <51A7B059.4000600@codesourcery.com> Date: Thu, 30 May 2013 13:02:33 -0700 From: Cesar Philippidis User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Subject: [PATCH] libitm testsuite fixes X-Virus-Found: No Here is a patch from our backlog that addresses a libitm issue where setting ENABLE_LTO=1 in site.exp causes the following error with dejagnu: ERROR: (DejaGnu) proc "libitm_target_compile linker_plugin19344.c linker_plugin19344.exe executable {{additional_flags=-flto -fuse-linker-plugin}}" does not exist. This problem usually does not occur since the default site.exp does not contain ENABLE_LTO=1. This patch has been tested both with and without our custom site.exp. Is this OK for trunk? If so, please check it in since I do not have commit rights. Cesar Philippidis 2013-05-30 Iain Sandoe Cesar Philippidis libitm/ * testsuite/lib/libitm.exp: Reorder lib loads into dependency order. Do not load_gcc_lib gcc-dg.exp and add a comment as to why. * testsuite/libitm.c/c.exp: load_gcc_lib gcc-dg.exp. * testsuite/libitm.c++/c++.exp: load_gcc_lib gcc-dg.exp. Index: libitm/testsuite/lib/libitm.exp =================================================================== --- libitm/testsuite/lib/libitm.exp (revision 199267) +++ libitm/testsuite/lib/libitm.exp (working copy) @@ -23,23 +23,27 @@ } load_lib dg.exp + +# Required to use gcc-dg.exp - however, the latter should NOT be +# loaded until ${tool}_target_compile is defined since it uses that +# to determine default LTO options. + +load_gcc_lib prune.exp +load_gcc_lib target-libpath.exp +load_gcc_lib wrapper.exp +load_gcc_lib gcc-defs.exp +load_gcc_lib timeout.exp +load_gcc_lib target-supports.exp load_gcc_lib file-format.exp -load_gcc_lib target-supports.exp load_gcc_lib target-supports-dg.exp load_gcc_lib scanasm.exp load_gcc_lib scandump.exp load_gcc_lib scanrtl.exp load_gcc_lib scantree.exp load_gcc_lib scanipa.exp -load_gcc_lib prune.exp -load_gcc_lib target-libpath.exp -load_gcc_lib wrapper.exp -load_gcc_lib gcc-defs.exp +load_gcc_lib timeout-dg.exp load_gcc_lib torture-options.exp -load_gcc_lib timeout.exp -load_gcc_lib timeout-dg.exp load_gcc_lib fortran-modules.exp -load_gcc_lib gcc-dg.exp set dg-do-what-default run Index: libitm/testsuite/libitm.c++/c++.exp =================================================================== --- libitm/testsuite/libitm.c++/c++.exp (revision 199267) +++ libitm/testsuite/libitm.c++/c++.exp (working copy) @@ -15,6 +15,7 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. load_lib libitm-dg.exp +load_gcc_lib gcc-dg.exp global shlib_ext Index: libitm/testsuite/libitm.c/c.exp =================================================================== --- libitm/testsuite/libitm.c/c.exp (revision 199267) +++ libitm/testsuite/libitm.c/c.exp (working copy) @@ -21,6 +21,7 @@ } load_lib libitm-dg.exp +load_gcc_lib gcc-dg.exp # If a testcase doesn't have special options, use these. if ![info exists DEFAULT_CFLAGS] then {