Message ID | C6CA53A2A46BA7469348BDBD663AB6585308BBBA@KCHJEXMB02.kpit.com |
---|---|
State | New |
Headers | show |
On 2013-05-30 06:25, Kaushik Phatak wrote: > Ping. > Can I commit this with below changes? > > Thanks, > Kaushik > > -----Original Message----- > From: Kaushik Phatak > Sent: 20 May 2013 20:17 > To: gcc-patches@gcc.gnu.org > Cc: 'Richard Henderson'; DJ Delorie (dj@redhat.com) > Subject: RE: [PATCH:RL78] Add new insn for mulqi3 and mulhi3 > > Hi Richard, > Thanks for the quick review. > >> No constraints on define_expand, only predicates. >>> +(define_insn "mulhi3_g13" >> These names are not used. They should be prefixed with "*" to indicate the name is just for documentation. > > I have made the suggested changes. Please find below an updated version of this patch. > Let me know if OK to commit the same. > Yes, this is fine. r~
Index: gcc/config/rl78/rl78.md =================================================================== --- gcc/config/rl78/rl78.md (revision 199105) +++ gcc/config/rl78/rl78.md (working copy) @@ -235,6 +235,24 @@ [(set_attr "valloc" "macax")] ) +(define_expand "mulqi3" + [(set (match_operand:QI 0 "register_operand" "") + (mult:QI (match_operand:QI 1 "general_operand" "") + (match_operand:QI 2 "nonmemory_operand" ""))) + ] + "" ; mulu supported by all targets + "" +) + +(define_expand "mulhi3" + [(set (match_operand:HI 0 "register_operand" "") + (mult:HI (match_operand:HI 1 "general_operand" "") + (match_operand:HI 2 "nonmemory_operand" ""))) + ] + "! RL78_MUL_NONE" + "" +) + (define_expand "mulsi3" [(set (match_operand:SI 0 "register_operand" "=&v") (mult:SI (match_operand:SI 1 "nonmemory_operand" "vi") @@ -244,6 +262,55 @@