Patchwork virtio-pci: drop unused wmb macro

login
register
mail settings
Submitter Michael S. Tsirkin
Date May 30, 2013, 9:28 a.m.
Message ID <1369906101-22329-1-git-send-email-mst@redhat.com>
Download mbox | patch
Permalink /patch/247505/
State New
Headers show

Comments

Michael S. Tsirkin - May 30, 2013, 9:28 a.m.
The implementation is wrong for kvm, and it's unused anyway.
Drop it.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Message-id: 20130528102023.GA30055@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
 hw/virtio/virtio-pci.c | 6 ------
 1 file changed, 6 deletions(-)
Anthony Liguori - May 31, 2013, 6:48 p.m.
Applied.  Thanks.

Regards,

Anthony Liguori

Patch

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 70d2c6b..444b71a 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -89,12 +89,6 @@ 
 /* Flags track per-device state like workarounds for quirks in older guests. */
 #define VIRTIO_PCI_FLAG_BUS_MASTER_BUG  (1 << 0)
 
-/* QEMU doesn't strictly need write barriers since everything runs in
- * lock-step.  We'll leave the calls to wmb() in though to make it obvious for
- * KVM or if kqemu gets SMP support.
- */
-#define wmb() do { } while (0)
-
 /* HACK for virtio to determine if it's running a big endian guest */
 bool virtio_is_big_endian(void);