Patchwork [libnftables] data_reg: xml: fix using bad temp variable

login
register
mail settings
Submitter Arturo Borrero
Date May 29, 2013, 10:45 p.m.
Message ID <20130529224506.18081.1971.stgit@nfdev.cica.es>
Download mbox | patch
Permalink /patch/247431/
State Accepted
Delegated to: Pablo Neira
Headers show

Comments

Arturo Borrero - May 29, 2013, 10:45 p.m.
This is a bug. It should use 'utmp' instead of 'tmp'.

Signed-off-by: Arturo Borero Gonzalez <arturo.borrero.glez@gmail.com>
---
 src/expr/data_reg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pablo Neira - June 5, 2013, 3:05 a.m.
On Thu, May 30, 2013 at 12:45:06AM +0200, Arturo Borrero wrote:
> This is a bug. It should use 'utmp' instead of 'tmp'.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/src/expr/data_reg.c b/src/expr/data_reg.c
index cf74888..71b10fe 100644
--- a/src/expr/data_reg.c
+++ b/src/expr/data_reg.c
@@ -204,7 +204,7 @@  static int nft_data_reg_value_xml_parse(union nft_data_reg *reg, char *xml)
 			mxmlDelete(tree);
 			return -1;
 		}
-		reg->val[i] = tmp;
+		reg->val[i] = utmp;
 	}
 
 	reg->len = sizeof(reg->val);