Patchwork [v2] gianfar: Create net device with carrier down

mail settings
Submitter Trent Piepho
Date Oct. 2, 2008, 9:12 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/2474/
State Accepted
Delegated to: Jeff Garzik
Headers show


Trent Piepho - Oct. 2, 2008, 9:12 p.m.
The device's carrier status is controlled via the functions
netif_carrier_on() and netif_carrier_off().  These set or clear a bit
indicating the carrier (aka lower level link) is down, and if the state
changed, they fire off a routing netlink event.

Add a call to netif_carrier_off() before register_netdev() so that the
newly created device will be set to carrier down.  Then when the carrier
comes up for the first time, a netlink event will be generated, as the
carrier changed from down to up.  Otherwise the initial carrier up will
appear to be changing the status from up to up, and so no event is
generated since that's not a change.

Signed-off-by: Trent Piepho <>
CC: Andy Fleming <>
This uses Stephen's suggestion, which works fine.  I had already tried this
in ->open(), but that creates bogus carrier up->carrier down->carrier up
netlink events when the device is opened.

 drivers/net/gianfar.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)


diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index a671270..484cf69 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -339,6 +339,9 @@  static int gfar_probe(struct platform_device *pdev)
 	/* Enable most messages by default */
 	priv->msg_enable = (NETIF_MSG_IFUP << 1 ) - 1;
+	/* Carrier starts down, phylib will bring it up */
+	netif_carrier_off(dev);
 	err = register_netdev(dev);
 	if (err) {