Patchwork ahci: add an observed PCI ID for Marvell 88se9172 SATA controller

login
register
mail settings
Submitter Tejun Heo
Date May 29, 2013, 1:22 a.m.
Message ID <20130529012231.GB2874@mtj.dyndns.org>
Download mbox | patch
Permalink /patch/247085/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Tejun Heo - May 29, 2013, 1:22 a.m.
Applied to libata/for-3.10-fixes.  In the future, please base patches
on top of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git
for-XXX branches.

Thanks.

From fcce9a35f8faaa1f52236c554ef1b15d99a7537e Mon Sep 17 00:00:00 2001
From: George Spelvin <linux@horizon.com>
Date: Wed, 29 May 2013 10:20:35 +0900

A third possible PCI ID, as personally observed, and found in the
pci.ids list.

Signed-off-by: George Spelvin <linux@horizon.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
---
 drivers/ata/ahci.c | 2 ++
 1 file changed, 2 insertions(+)
George Spelvin - May 29, 2013, 12:36 p.m.
> Applied to libata/for-3.10-fixes.  In the future, please base patches
> on top of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git
> for-XXX branches.

As you saw, it didn't initially occur to me to prepare a patch at all;
it seemed such a trivial copy/paste/one-character-edit exercise.
After diagnosis, the most difficult part was writing a meaningful
commit message.

Which I presumed would be easier for you; a lot of the difficulty for me
was trying to figure out one line that would fit the ongoing narrative
that is the kernel changelog.

I was actually surprised when you asked for a full patch, so I just sent
you a copy of my private commit, with an improved commit message and S-o-b.
(Should I have added "Cc: stable" to it?)

But since I now know you prefer even trivial changes like this in formal
patch form, I'll try to do it right in future.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tejun Heo - May 30, 2013, 6:52 a.m.
Hello,

On Wed, May 29, 2013 at 08:36:27AM -0400, George Spelvin wrote:
> As you saw, it didn't initially occur to me to prepare a patch at all;
> it seemed such a trivial copy/paste/one-character-edit exercise.
> After diagnosis, the most difficult part was writing a meaningful
> commit message.
> 
> Which I presumed would be easier for you; a lot of the difficulty for me
> was trying to figure out one line that would fit the ongoing narrative
> that is the kernel changelog.
> 
> I was actually surprised when you asked for a full patch, so I just sent
> you a copy of my private commit, with an improved commit message and S-o-b.
> (Should I have added "Cc: stable" to it?)
> 
> But since I now know you prefer even trivial changes like this in formal
> patch form, I'll try to do it right in future.

It's partly for convenience on my part but more to attribute changes
correctly.  This is something you did so if at all possible I'd like
you to take the credit and (however minute it may be) the accompanying
responsibility.  It doesn't have to be perfect and I'm happy to edit
the commit messages / patches as necessary and adding cc to stable.
Well, at least unless you're gonna be submitting large volume of
patches.

Thanks.

Patch

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 2180876..2b50dfd 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -423,6 +423,8 @@  static const struct pci_device_id ahci_pci_tbl[] = {
 	  .driver_data = board_ahci_yes_fbs },			/* 88se9125 */
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x917a),
 	  .driver_data = board_ahci_yes_fbs },			/* 88se9172 */
+	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x9172),
+	  .driver_data = board_ahci_yes_fbs },			/* 88se9172 */
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x9192),
 	  .driver_data = board_ahci_yes_fbs },			/* 88se9172 on some Gigabyte */
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x91a3),