From patchwork Tue May 28 22:37:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 247050 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id A045B2C032A for ; Wed, 29 May 2013 08:38:05 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:content-transfer-encoding; q=dns; s= default; b=jNK3ReK5eEjxD2ELEBu1sPKyqEoPdj2IrgY+kIbhEKaUgS1yOeF0S zLdxJR5HTdL1z6I94sRwfIZfzprKq7Yjh7Y2LYq6Uc1gIbnBDzJOWzLN76+ZIU19 lx5ONZ69uGMmD2E+34uj32L4dZzgzrVX1cNonofaquDHUjsmOzpP8E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:content-transfer-encoding; s=default; bh=KM/oc3jNpgJN+s1zMaSqqQNQEdc=; b=IA9DlZzJzdWsIHVZr5PxMyuZ3gjz VqqaHGb0OqbMHTrP+tNf6gW27aEVufyqOzACztRx0oDqiddxoRorbvZA3NSaEE+n tsw7HG6Iaipo+Ji/pbuuDsBKzmeBjhG/SBP2s/uF28vPZ2mx59ebdbJRYcvwHBqE rifWvXueI9iFsUE= Received: (qmail 9888 invoked by alias); 28 May 2013 22:37:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 9877 invoked by uid 89); 28 May 2013 22:37:58 -0000 X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from multi.imgtec.com (HELO multi.imgtec.com) (194.200.65.239) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 28 May 2013 22:37:57 +0000 Subject: Re: [patch, mips] Patch for mips generic scheduler From: Steve Ellcey To: Richard Sandiford CC: In-Reply-To: <87y5b7jzku.fsf@talisman.default> References: <9714dd4b-6beb-4007-9bf4-c9ee80ab5ad6@BAMAIL02.ba.imgtec.org> <877giskvra.fsf@talisman.default> <1369169260.1688.132.camel@ubuntu-sellcey> <87y5b7jzku.fsf@talisman.default> Date: Tue, 28 May 2013 15:37:50 -0700 Message-ID: <1369780670.12204.44.camel@ubuntu-sellcey> MIME-Version: 1.0 X-SEF-Processed: 7_3_0_01181__2013_05_28_23_37_54 On Wed, 2013-05-22 at 07:30 +0100, Richard Sandiford wrote: > Oops -- only if someone submitted one :-) So we should definitely > change the mips32r2 entry. I'd suggest one of PROCESSOR_24KF* or > PROCESSOR_74KF*, so that we get the FPU scheduling, but I don't know > which would be more representative of the general case. TUNE_74* > has quite a lot of special code associated with it, whereas TUNE_24* > sets TUNE_MACC_CHAINS, which might overemphasise the use of MADD > for 74k targets when -mimadd is used. > > But any choice is going to be a compromise. A patch to do either > is preapproved. > > Thanks, > Richard OK, I did some testing and benchmarking and did not find a clear best choice so I think I will go with PROCESSOR_74KF2_1. Here is the patch I will check in shortly: 2013-05-28 Steve Ellcey * config/mips/mips-cpus.def (mips32r2): Change processor type. diff --git a/gcc/config/mips/mips-cpus.def b/gcc/config/mips/mips-cpus.def index 9e5fd16..f08fad6 100644 --- a/gcc/config/mips/mips-cpus.def +++ b/gcc/config/mips/mips-cpus.def @@ -43,7 +43,7 @@ MIPS_CPU ("mips4", PROCESSOR_R8000, 4, 0) that to a recommendation to avoid the instructions in code that isn't tuned to a specific processor. */ MIPS_CPU ("mips32", PROCESSOR_4KC, 32, PTF_AVOID_BRANCHLIKELY) -MIPS_CPU ("mips32r2", PROCESSOR_M4K, 33, PTF_AVOID_BRANCHLIKELY) +MIPS_CPU ("mips32r2", PROCESSOR_74KF2_1, 33, PTF_AVOID_BRANCHLIKELY) MIPS_CPU ("mips64", PROCESSOR_5KC, 64, PTF_AVOID_BRANCHLIKELY) /* ??? For now just tune the generic MIPS64r2 for 5KC as well. */ MIPS_CPU ("mips64r2", PROCESSOR_5KC, 65, PTF_AVOID_BRANCHLIKELY)