Patchwork [mips] Patch for mips generic scheduler

login
register
mail settings
Submitter Steve Ellcey
Date May 28, 2013, 10:37 p.m.
Message ID <1369780670.12204.44.camel@ubuntu-sellcey>
Download mbox | patch
Permalink /patch/247050/
State New
Headers show

Comments

Steve Ellcey - May 28, 2013, 10:37 p.m.
On Wed, 2013-05-22 at 07:30 +0100, Richard Sandiford wrote:

> Oops -- only if someone submitted one :-)  So we should definitely
> change the mips32r2 entry.  I'd suggest one of PROCESSOR_24KF* or
> PROCESSOR_74KF*, so that we get the FPU scheduling, but I don't know
> which would be more representative of the general case.  TUNE_74*
> has quite a lot of special code associated with it, whereas TUNE_24*
> sets TUNE_MACC_CHAINS, which might overemphasise the use of MADD
> for 74k targets when -mimadd is used.
> 
> But any choice is going to be a compromise.  A patch to do either
> is preapproved.
> 
> Thanks,
> Richard

OK, I did some testing and benchmarking and did not find a clear best
choice so I think I will go with PROCESSOR_74KF2_1.  Here is the patch
I will check in shortly:



2013-05-28  Steve Ellcey  <sellcey@mips.com>

	* config/mips/mips-cpus.def (mips32r2): Change processor type.

Patch

diff --git a/gcc/config/mips/mips-cpus.def
b/gcc/config/mips/mips-cpus.def
index 9e5fd16..f08fad6 100644
--- a/gcc/config/mips/mips-cpus.def
+++ b/gcc/config/mips/mips-cpus.def
@@ -43,7 +43,7 @@  MIPS_CPU ("mips4", PROCESSOR_R8000, 4, 0)
    that to a recommendation to avoid the instructions in code that
    isn't tuned to a specific processor.  */
 MIPS_CPU ("mips32", PROCESSOR_4KC, 32, PTF_AVOID_BRANCHLIKELY)
-MIPS_CPU ("mips32r2", PROCESSOR_M4K, 33, PTF_AVOID_BRANCHLIKELY)
+MIPS_CPU ("mips32r2", PROCESSOR_74KF2_1, 33, PTF_AVOID_BRANCHLIKELY)
 MIPS_CPU ("mips64", PROCESSOR_5KC, 64, PTF_AVOID_BRANCHLIKELY)
 /* ??? For now just tune the generic MIPS64r2 for 5KC as well.   */
 MIPS_CPU ("mips64r2", PROCESSOR_5KC, 65, PTF_AVOID_BRANCHLIKELY)