Patchwork [-next] fsl_pq_mdio: Revive Gianfar TBI PHY support

login
register
mail settings
Submitter Anton Vorontsov
Date March 19, 2009, 3:52 p.m.
Message ID <20090319155232.GA5419@oksana.dev.rtsoft.ru>
Download mbox | patch
Permalink /patch/24694/
State Accepted, archived
Headers show

Comments

Anton Vorontsov - March 19, 2009, 3:52 p.m.
commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
and gianfar MDIO bus drivers") broke the TSEC TBI PHY support: the
driver now refuses to probe TBI MDIO buses as it doesn't know about
"fsl,gianfar-tbi" compatible entry, and thus _probe() fails with
-ENODEV status.

Fix this by adding "fsl,gianfar-tbi" to the list of known Gianfar
MDIO buses.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/net/fsl_pq_mdio.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Andy Fleming - March 19, 2009, 3:56 p.m.
On Mar 19, 2009, at 10:52 AM, Anton Vorontsov wrote:

> commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
> and gianfar MDIO bus drivers") broke the TSEC TBI PHY support: the
> driver now refuses to probe TBI MDIO buses as it doesn't know about
> "fsl,gianfar-tbi" compatible entry, and thus _probe() fails with
> -ENODEV status.
>
> Fix this by adding "fsl,gianfar-tbi" to the list of known Gianfar
> MDIO buses.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

Acked-by: Andy Fleming <afleming@freescale.com>
David Miller - March 21, 2009, 8:30 p.m.
From: Andy Fleming <afleming@freescale.com>
Date: Thu, 19 Mar 2009 10:56:59 -0500

> 
> On Mar 19, 2009, at 10:52 AM, Anton Vorontsov wrote:
> 
> > commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 ("netdev: Merge UCC
> > and gianfar MDIO bus drivers") broke the TSEC TBI PHY support: the
 ...
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> 
> Acked-by: Andy Fleming <afleming@freescale.com>

Applied

Patch

diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
index b0ce144..6be36b9 100644
--- a/drivers/net/fsl_pq_mdio.c
+++ b/drivers/net/fsl_pq_mdio.c
@@ -321,6 +321,7 @@  static int fsl_pq_mdio_probe(struct of_device *ofdev,
 	dev_set_drvdata(&ofdev->dev, new_bus);
 
 	if (of_device_is_compatible(np, "fsl,gianfar-mdio") ||
+			of_device_is_compatible(np, "fsl,gianfar-tbi") ||
 			of_device_is_compatible(np, "gianfar")) {
 #ifdef CONFIG_GIANFAR
 		tbipa = get_gfar_tbipa(regs);