Patchwork [libnftables] rule: fix table flag not being set at XML parsing

login
register
mail settings
Submitter Arturo Borrero
Date May 28, 2013, 3:06 p.m.
Message ID <20130528150608.5236.81847.stgit@nfdev.cica.es>
Download mbox | patch
Permalink /patch/246879/
State Accepted
Headers show

Comments

Arturo Borrero - May 28, 2013, 3:06 p.m.
This bug was introduced by me at commit:

	'src: add support for XML parsing'
	51370f0eedb1c8167ab2c340d2a53f0d9f02509c

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 src/rule.c |    1 +
 1 file changed, 1 insertion(+)


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pablo Neira - May 29, 2013, 12:11 p.m.
On Tue, May 28, 2013 at 05:06:08PM +0200, Arturo Borrero wrote:
> This bug was introduced by me at commit:
> 
> 	'src: add support for XML parsing'
> 	51370f0eedb1c8167ab2c340d2a53f0d9f02509c

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/src/rule.c b/src/rule.c
index 318ae07..4d56d5a 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -479,6 +479,7 @@  static int nft_rule_xml_parse(struct nft_rule *r, char *xml)
 		free(r->table);
 
 	r->table = strdup(mxmlElementGetAttr(tree, "table"));
+	r->flags |= (1 << NFT_RULE_ATTR_TABLE);
 
 	/* get and set <rule ... chain=X ...> */
 	if (mxmlElementGetAttr(tree, "chain") == NULL) {