| Message ID | 1369738614-31476-1-git-send-email-jerzy.grzegorek@trzebnica.net |
|---|---|
| State | Accepted |
| Commit | fee470d0d3e236b78f7cd0cfbccb40e4ab0e0a48 |
| Headers | show |
Dear Jerzy Grzegorek, On Tue, 28 May 2013 12:56:54 +0200, Jerzy Grzegorek wrote: > Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net> > --- > ...r-0001-attr-Fix-static-build-installation.patch | 30 -------------------- Can you confirm that this patch has been integrated in the new upstream version? Generally speaking, when bumping to a new upstream version involves removing/adding patches, it would be nice to have a slightly more detailed commit log that explains why patches are added/removed. Thanks! Thomas
On Tue, May 28, 2013 at 6:07 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Jerzy Grzegorek, > > On Tue, 28 May 2013 12:56:54 +0200, Jerzy Grzegorek wrote: >> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net> >> --- >> ...r-0001-attr-Fix-static-build-installation.patch | 30 -------------------- > > Can you confirm that this patch has been integrated in the new upstream > version? > > Generally speaking, when bumping to a new upstream version involves > removing/adding patches, it would be nice to have a slightly more > detailed commit log that explains why patches are added/removed. > > Thanks! > > Thomas > -- > Thomas Petazzoni, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot Thomas, I investigated this issue a while ago for fun and I don't think that patch ever worked. Many (maybe all) of the autobuild failures on acl were because there was no static library of attr to link against. Spenser -- Spenser Gilliland Computer Engineer Doctoral Candidate
Dear Spenser Gilliland, On Tue, 28 May 2013 09:02:56 -0500, Spenser Gilliland wrote: > I investigated this issue a while ago for fun and I don't think that > patch ever worked. Many (maybe all) of the autobuild failures on acl > were because there was no static library of attr to link against. Are you insinuating that my patch was not correct? :-) Come on, this never happens to me! If you look at 5ad2879a8bca386fa5c256a4286ccc928601cc1a, the purpose of the patch was not really to fix *other* libraries linking against the static version of attr, but rather fix the attr build process *itself* which was crashing when BR2_PREFER_STATIC_LIB=y. See http://autobuild.buildroot.org/results/58a3d4113172813183d43fddc1248b35bd0c4994/build-end.log That said, if other packages were still not able to link statically against attr after that patch, then clearly it means that the patch was not sufficient. Thomas
Thomas, > Are you insinuating that my patch was not correct? :-) Come on, this > never happens to me! Of course not! I'm just saying that maybe somewhere along the line you may have overlooked the small aspect of installing the static version of the library. :-) > If you look at 5ad2879a8bca386fa5c256a4286ccc928601cc1a, the purpose of > the patch was not really to fix *other* libraries linking against the > static version of attr, but rather fix the attr build process *itself* > which was crashing when BR2_PREFER_STATIC_LIB=y. > > See > http://autobuild.buildroot.org/results/58a3d4113172813183d43fddc1248b35bd0c4994/build-end.log There is a libtool .la library in the folder where it is looking for a .lai . I don't understand libtool well enough to understand what the difference is between a .la and .lai library. Thus, I quit working on it. > That said, if other packages were still not able to link statically > against attr after that patch, then clearly it means that the patch was > not sufficient. > > Thomas > -- > Thomas Petazzoni, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com -- Spenser Gilliland Computer Engineer Doctoral Candidate
diff --git a/package/attr/attr-0001-attr-Fix-static-build-installation.patch b/package/attr/attr-0001-attr-Fix-static-build-installation.patch deleted file mode 100644 index ed51dbb..0000000 --- a/package/attr/attr-0001-attr-Fix-static-build-installation.patch +++ /dev/null @@ -1,30 +0,0 @@ -From 1d510e6049e7c7cb7ed4e87780b2c1a997d47b64 Mon Sep 17 00:00:00 2001 -From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> -Date: Sat, 17 Nov 2012 19:36:39 +0100 -Subject: [PATCH] attr: Fix static build installation - -When doing a static build the .lai file is not created, so do not try -to install it. - -Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> ---- - include/buildmacros | 3 +-- - 1 file changed, 1 insertion(+), 2 deletions(-) - -diff --git a/include/buildmacros b/include/buildmacros -index ab89182..d81e62b 100644 ---- a/include/buildmacros -+++ b/include/buildmacros -@@ -98,8 +98,7 @@ endif - - INSTALL_LTLIB_STATIC = \ - cd $(TOPDIR)/$(LIBNAME)/.libs; \ -- ../$(INSTALL) -m 755 -d $(PKG_DEVLIB_DIR); \ -- ../$(INSTALL) -m 644 -T old_lib $(LIBNAME).lai $(PKG_DEVLIB_DIR) -+ ../$(INSTALL) -m 755 -d $(PKG_DEVLIB_DIR); - - INSTALL_MAN = \ - @for d in $(MAN_PAGES); do \ --- -1.7.9.5 - diff --git a/package/attr/attr.mk b/package/attr/attr.mk index 288052d..2b67010 100644 --- a/package/attr/attr.mk +++ b/package/attr/attr.mk @@ -4,7 +4,7 @@ # ############################################################# -ATTR_VERSION = 2.4.46 +ATTR_VERSION = 2.4.47 ATTR_SOURCE = attr-$(ATTR_VERSION).src.tar.gz ATTR_SITE = http://download.savannah.gnu.org/releases/attr ATTR_INSTALL_STAGING = YES
Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net> --- ...r-0001-attr-Fix-static-build-installation.patch | 30 -------------------- package/attr/attr.mk | 2 +- 2 files changed, 1 insertion(+), 31 deletions(-) delete mode 100644 package/attr/attr-0001-attr-Fix-static-build-installation.patch