From patchwork Tue May 28 10:20:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 246814 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E3B0D2C030F for ; Tue, 28 May 2013 20:20:33 +1000 (EST) Received: from localhost ([::1]:47113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhH16-0004Pq-2O for incoming@patchwork.ozlabs.org; Tue, 28 May 2013 06:20:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhH0j-0004Oj-Qm for qemu-devel@nongnu.org; Tue, 28 May 2013 06:20:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhH0f-00064j-Vr for qemu-devel@nongnu.org; Tue, 28 May 2013 06:20:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhH0f-00063U-OX for qemu-devel@nongnu.org; Tue, 28 May 2013 06:20:05 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4SAK1QZ023204 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 28 May 2013 06:20:01 -0400 Received: from redhat.com (vpn-202-197.tlv.redhat.com [10.35.202.197]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id r4SAJw7M027813; Tue, 28 May 2013 06:19:59 -0400 Date: Tue, 28 May 2013 13:20:23 +0300 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20130528102023.GA30055@redhat.com> MIME-Version: 1.0 Content-Disposition: inline X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Peter Maydell , Paolo Bonzini , Anthony Liguori , KONRAD Frederic Subject: [Qemu-devel] [PATCH] virtio-pci: drop unused wmb macro X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The implementation is wrong for kvm, and it's unused anyway. Drop it. Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 87b78bc..f4db224 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -89,12 +89,6 @@ /* Flags track per-device state like workarounds for quirks in older guests. */ #define VIRTIO_PCI_FLAG_BUS_MASTER_BUG (1 << 0) -/* QEMU doesn't strictly need write barriers since everything runs in - * lock-step. We'll leave the calls to wmb() in though to make it obvious for - * KVM or if kqemu gets SMP support. - */ -#define wmb() do { } while (0) - /* HACK for virtio to determine if it's running a big endian guest */ bool virtio_is_big_endian(void);