Message ID | 1369731347-9994-4-git-send-email-b18965@freescale.com |
---|---|
State | Awaiting Upstream |
Delegated to: | Stefano Babic |
Headers | show |
Hi Alison, On Tuesday, May 28, 2013 10:55:43 AM, Alison Wang wrote: > This patch adds FEC support for Vybrid VF610 platform. > > In function fec_open(), RCR register is only set as RGMII mode. But RCR > register should be set as RMII mode for VF610 platform. > This configuration is already done in fec_reg_setup(), so this piece of > code could just leave untouched the FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / > FEC_RCNTRL_MII_MODE bits. [...] Reviewed-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com> Best regards, Benoît
On 28/05/2013 10:55, Alison Wang wrote: > This patch adds FEC support for Vybrid VF610 platform. > > In function fec_open(), RCR register is only set as RGMII mode. But RCR > register should be set as RMII mode for VF610 platform. > This configuration is already done in fec_reg_setup(), so this piece of > code could just leave untouched the FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / > FEC_RCNTRL_MII_MODE bits. > > Signed-off-by: Alison Wang <b18965@freescale.com> > Reviewed-by: Benoit Thebaudeau <benoit.thebaudeau@advansee.com> > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic
diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 4dbcdca..da95e28 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -516,9 +516,7 @@ static int fec_open(struct eth_device *edev) #ifdef FEC_QUIRK_ENET_MAC { u32 ecr = readl(&fec->eth->ecntrl) & ~FEC_ECNTRL_SPEED; - u32 rcr = (readl(&fec->eth->r_cntrl) & - ~(FEC_RCNTRL_RMII | FEC_RCNTRL_RMII_10T)) | - FEC_RCNTRL_RGMII | FEC_RCNTRL_MII_MODE; + u32 rcr = readl(&fec->eth->r_cntrl) & ~FEC_RCNTRL_RMII_10T; if (speed == _1000BASET) ecr |= FEC_ECNTRL_SPEED; else if (speed != _100BASET)