Patchwork Default to --enable-libstdcxx-time=auto

login
register
mail settings
Submitter Rainer Orth
Date May 28, 2013, 9:41 a.m.
Message ID <yddwqqjsaox.fsf@lokon.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/246766/
State New
Headers show

Comments

Rainer Orth - May 28, 2013, 9:41 a.m.
Jakub Jelinek <jakub@redhat.com> writes:

> On Sun, May 26, 2013 at 07:58:09AM +0200, Jakub Jelinek wrote:
>> On Sat, May 25, 2013 at 04:07:11PM -0700, Benjamin De Kosnik wrote:
>> > 
>> > > Looks good to me.  
>> > 
>> > Great, trunk patch in.
>> > 
>> > > Will you prepare corresponding patch for the 4.8
>> > > branch too (I guess it should be pretty much the same, not sure if it
>> > > should keep using typedef system_clock steady_clock as before for the
>> > > non-MONOTONIC configuration, or if it should just do the same thing
>> > > as trunk)?
>> > 
>> > Same thing, I think. Testing now, ok when it completes?
>> 
>> Yes, thanks.
>
> My bootstraps on x86_64-linux and i686-linux on 4.8 branch were ok, so I
> went ahead and committed the backport of your patch (applied cleanly).

Testing friday night's patch has completed successfully on both mainline
and 4.8 branch.  I've now retested on sparc-sun-solaris2.9,
sparc-sun-solaris2.11, i386-pc-solaris2.9 and i386-pc-solaris2.10, which
found a glitch: on Solaris 11/SPARC only, I get

  sparc-sun-solaris2.11:

 Running target unix/-m64
+FAIL: libstdc++-abi/abi_check

                ==== libstdc++-v3 check-abi Summary ====

# of added symbols:              0
# of missing symbols:            1
# of undesignated symbols:       0
# of incompatible symbols:       1

1 missing symbols
0
_ZNSt6chrono12steady_clock3nowEv
std::chrono::steady_clock::now()
version status: unversioned
type: function
status: subtracted


1 incompatible symbols
0
_ZNSt6chrono12steady_clock3nowEv
std::chrono::steady_clock::now()
version status: unversioned
type: function
status: subtracted

Fixed by the following patch, tested with the appropriate runtest
invocation on sparc-sun-solaris2.11.

Ok for mainline and 4.8 branch?

The only remaining Solaris now remains what to do about linking with
-lrt on mainline.  My mainline bootstraps have included this patch

	http://gcc.gnu.org/ml/gcc-patches/2013-05/msg01488.html

to avoid several failures.

Thanks.

	Rainer


2013-05-28  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* config/abi/post/solaris2.10/sparcv9/baseline_symbols.txt:
	Regenerate.
Jakub Jelinek - May 28, 2013, 9:46 a.m.
On Tue, May 28, 2013 at 11:41:50AM +0200, Rainer Orth wrote:
> Fixed by the following patch, tested with the appropriate runtest
> invocation on sparc-sun-solaris2.11.
> 
> Ok for mainline and 4.8 branch?

Yes, thanks.

> 2013-05-28  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 
> 	* config/abi/post/solaris2.10/sparcv9/baseline_symbols.txt:
> 	Regenerate.

> # HG changeset patch
> # Parent a21f2aac856e49876b3e5ecd1bc15b91f3a881af
> Regenerate Solaris/SPARCV9 baseline
> 
> diff --git a/libstdc++-v3/config/abi/post/solaris2.10/sparcv9/baseline_symbols.txt b/libstdc++-v3/config/abi/post/solaris2.10/sparcv9/baseline_symbols.txt
> --- a/libstdc++-v3/config/abi/post/solaris2.10/sparcv9/baseline_symbols.txt
> +++ b/libstdc++-v3/config/abi/post/solaris2.10/sparcv9/baseline_symbols.txt
> @@ -1904,7 +1904,6 @@ FUNC:_ZNSt6__norm15_List_node_base7_M_ho
>  FUNC:_ZNSt6__norm15_List_node_base7reverseEv@@GLIBCXX_3.4.9
>  FUNC:_ZNSt6__norm15_List_node_base8transferEPS0_S1_@@GLIBCXX_3.4.9
>  FUNC:_ZNSt6__norm15_List_node_base9_M_unhookEv@@GLIBCXX_3.4.14
> -FUNC:_ZNSt6chrono12steady_clock3nowEv@@GLIBCXX_3.4.19
>  FUNC:_ZNSt6chrono12system_clock3nowEv@@GLIBCXX_3.4.11
>  FUNC:_ZNSt6gslice8_IndexerC1EmRKSt8valarrayImES4_@@GLIBCXX_3.4
>  FUNC:_ZNSt6gslice8_IndexerC2EmRKSt8valarrayImES4_@@GLIBCXX_3.4

	Jakub

Patch

# HG changeset patch
# Parent a21f2aac856e49876b3e5ecd1bc15b91f3a881af
Regenerate Solaris/SPARCV9 baseline

diff --git a/libstdc++-v3/config/abi/post/solaris2.10/sparcv9/baseline_symbols.txt b/libstdc++-v3/config/abi/post/solaris2.10/sparcv9/baseline_symbols.txt
--- a/libstdc++-v3/config/abi/post/solaris2.10/sparcv9/baseline_symbols.txt
+++ b/libstdc++-v3/config/abi/post/solaris2.10/sparcv9/baseline_symbols.txt
@@ -1904,7 +1904,6 @@  FUNC:_ZNSt6__norm15_List_node_base7_M_ho
 FUNC:_ZNSt6__norm15_List_node_base7reverseEv@@GLIBCXX_3.4.9
 FUNC:_ZNSt6__norm15_List_node_base8transferEPS0_S1_@@GLIBCXX_3.4.9
 FUNC:_ZNSt6__norm15_List_node_base9_M_unhookEv@@GLIBCXX_3.4.14
-FUNC:_ZNSt6chrono12steady_clock3nowEv@@GLIBCXX_3.4.19
 FUNC:_ZNSt6chrono12system_clock3nowEv@@GLIBCXX_3.4.11
 FUNC:_ZNSt6gslice8_IndexerC1EmRKSt8valarrayImES4_@@GLIBCXX_3.4
 FUNC:_ZNSt6gslice8_IndexerC2EmRKSt8valarrayImES4_@@GLIBCXX_3.4