| Message ID | 1369722676-7898-1-git-send-email-fan.du@windriver.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Fan Du <fan.du@windriver.com> Date: Tue, 28 May 2013 14:31:16 +0800 > ovs_vport_cmd_new create a new vport with port num specified by user. > when this port num is already occupied, it's more clear to return > -EEXIST as the reason than -EBUSY. > > Signed-off-by: Fan Du <fan.du@windriver.com> Jesse? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 28, 2013 at 3:31 PM, Fan Du <fan.du@windriver.com> wrote: > ovs_vport_cmd_new create a new vport with port num specified by user. > when this port num is already occupied, it's more clear to return > -EEXIST as the reason than -EBUSY. > > Signed-off-by: Fan Du <fan.du@windriver.com> This error code is part of the userspace ABI so you can't change it without breaking existing applications. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index d12d6b8..1e31095 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -1755,7 +1755,7 @@ static int ovs_vport_cmd_new(struct sk_buff *skb, struct genl_info *info) goto exit_unlock; vport = ovs_vport_ovsl(dp, port_no); - err = -EBUSY; + err = -EEXIST; if (vport) goto exit_unlock; } else {
ovs_vport_cmd_new create a new vport with port num specified by user. when this port num is already occupied, it's more clear to return -EEXIST as the reason than -EBUSY. Signed-off-by: Fan Du <fan.du@windriver.com> --- net/openvswitch/datapath.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)