Patchwork smsc9420: fix big endian rx checksum offload

login
register
mail settings
Submitter Steve Glendinning
Date March 19, 2009, 11:12 a.m.
Message ID <1237461152-5519-1-git-send-email-steve.glendinning@smsc.com>
Download mbox | patch
Permalink /patch/24667/
State Accepted
Delegated to: David Miller
Headers show

Comments

Steve Glendinning - March 19, 2009, 11:12 a.m.
The cpu_to_le16 here looks suspicious to me, I don't think we need it
because put_unaligned_le16 also does this.

I don't currently have any big endian hardware with a PCI bus available
to test on, so I haven't been able to verify this.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
---
 drivers/net/smsc9420.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - March 20, 2009, 8:15 a.m.
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Thu, 19 Mar 2009 11:12:32 +0000

> The cpu_to_le16 here looks suspicious to me, I don't think we need it
> because put_unaligned_le16 also does this.
> 
> I don't currently have any big endian hardware with a PCI bus available
> to test on, so I haven't been able to verify this.
> 
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>

Looks good, applied.

skb->csum is never unaligned so you probably want to also
convert this to use one of the aligned endianness store
interfaces.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/smsc9420.c b/drivers/net/smsc9420.c
index 17560db..5959ae8 100644
--- a/drivers/net/smsc9420.c
+++ b/drivers/net/smsc9420.c
@@ -807,7 +807,7 @@  static void smsc9420_rx_handoff(struct smsc9420_pdata *pd, const int index,
 	if (pd->rx_csum) {
 		u16 hw_csum = get_unaligned_le16(skb_tail_pointer(skb) +
 			NET_IP_ALIGN + packet_length + 4);
-		put_unaligned_le16(cpu_to_le16(hw_csum), &skb->csum);
+		put_unaligned_le16(hw_csum, &skb->csum);
 		skb->ip_summed = CHECKSUM_COMPLETE;
 	}