| Message ID | 1369673122-20455-1-git-send-email-otavio@ossystems.com.br |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
Dear Otavio Salvador, In message <1369673122-20455-1-git-send-email-otavio@ossystems.com.br> you wrote: > The board needs to be under a 'wandboard' vendor so we can use it to > choose the proper Boot Splash image. > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > --- > Changes in v2: > - Fix indenting in boards.cfg NAK as for v1. Best regards, Wolfgang Denk
On Mon, May 27, 2013 at 6:23 PM, Wolfgang Denk <wd@denx.de> wrote: > Dear Otavio Salvador, > > In message <1369673122-20455-1-git-send-email-otavio@ossystems.com.br> > you wrote: > > The board needs to be under a 'wandboard' vendor so we can use it to > > choose the proper Boot Splash image. > > > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > > --- > > Changes in v2: > > - Fix indenting in boards.cfg > > NAK as for v1. How do you suggest me to handle it? I'd like to have the logo file used when building wandboard.
On Mon, May 27, 2013 at 6:27 PM, Otavio Salvador <otavio@ossystems.com.br>wrote: > > > > On Mon, May 27, 2013 at 6:23 PM, Wolfgang Denk <wd@denx.de> wrote: > >> Dear Otavio Salvador, >> >> In message <1369673122-20455-1-git-send-email-otavio@ossystems.com.br> >> you wrote: >> > The board needs to be under a 'wandboard' vendor so we can use it to >> > choose the proper Boot Splash image. >> > >> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> >> > --- >> > Changes in v2: >> > - Fix indenting in boards.cfg >> >> NAK as for v1. > > > How do you suggest me to handle it? I'd like to have the logo file used > when building wandboard. > I sent a v3 doing this. Please give it a look.
Dear Otavio Salvador, In message <CAP9ODKo=2zKLS5Ut6rgMPKuDpOXM1EjeVh8XV-fwDPjOkXZsuw@mail.gmail.com> you wrote: > > How do you suggest me to handle it? I'd like to have the logo file used > when building wandboard. Vendor subdirectories are used for vendors that support several boards, eventually sharing common code. Here this is not the case: "wandboard" is not a vendor name, and there will be no other boards from this "vendor" / under this name. As for the logo selection, the currecnt "ifeq ($(VENDOR),...)" approach in "tools/Makefile" does not scale and needs to be reworked. The "wandboard" case also shows that it makes no sense to depend this selection on $(VENDOR). So this is the point where to fix the issue: in "tools/Makefile". Best regards, Wolfgang Denk
diff --git a/board/wandboard/Makefile b/board/wandboard/wandboard/Makefile similarity index 100% rename from board/wandboard/Makefile rename to board/wandboard/wandboard/Makefile diff --git a/board/wandboard/README b/board/wandboard/wandboard/README similarity index 100% rename from board/wandboard/README rename to board/wandboard/wandboard/README diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard/wandboard.c similarity index 100% rename from board/wandboard/wandboard.c rename to board/wandboard/wandboard/wandboard.c diff --git a/boards.cfg b/boards.cfg index 2f39f26..a51165c 100644 --- a/boards.cfg +++ b/boards.cfg @@ -269,8 +269,8 @@ nitrogen6q arm armv7 nitrogen6x boundar nitrogen6q2g arm armv7 nitrogen6x boundary mx6 nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6q2g.cfg,MX6Q,DDR_MB=2048 nitrogen6s arm armv7 nitrogen6x boundary mx6 nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s.cfg,MX6S,DDR_MB=512 nitrogen6s1g arm armv7 nitrogen6x boundary mx6 nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s1g.cfg,MX6S,DDR_MB=1024 -wandboard_dl arm armv7 wandboard - mx6 wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl.cfg,MX6DL,DDR_MB=1024 -wandboard_solo arm armv7 wandboard - mx6 wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s.cfg,MX6S,DDR_MB=512 +wandboard_dl arm armv7 wandboard wandboard mx6 wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl.cfg,MX6DL,DDR_MB=1024 +wandboard_solo arm armv7 wandboard wandboard mx6 wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s.cfg,MX6S,DDR_MB=512 omap3_overo arm armv7 overo - omap3 omap3_pandora arm armv7 pandora - omap3 dig297 arm armv7 dig297 comelit omap3
The board needs to be under a 'wandboard' vendor so we can use it to choose the proper Boot Splash image. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> --- Changes in v2: - Fix indenting in boards.cfg board/wandboard/{ => }/wandboard/Makefile | 0 board/wandboard/{ => }/wandboard/README | 0 board/wandboard/{ => }/wandboard/wandboard.c | 0 boards.cfg | 4 ++-- 4 files changed, 2 insertions(+), 2 deletions(-) rename board/wandboard/{ => }/wandboard/Makefile (100%) rename board/wandboard/{ => }/wandboard/README (100%) rename board/wandboard/{ => }/wandboard/wandboard.c (100%)