Patchwork [U-Boot] Wandboard: Add support for Wandboard quad

login
register
mail settings
Submitter Tapani Utriainen
Date May 27, 2013, 4:13 a.m.
Message ID <20130527121309.66895de4@triceratops>
Download mbox | patch
Permalink /patch/246522/
State Superseded
Delegated to: Stefano Babic
Headers show

Comments

Tapani Utriainen - May 27, 2013, 4:13 a.m.
Add support for the Wandboard quad.

Signed-off-by: Tapani Utriainen <tapani@technexion.com>

---
 boards.cfg                  | 1 +
 include/configs/wandboard.h | 2 ++
 2 files changed, 3 insertions(+)
Fabio Estevam - May 27, 2013, 10:22 a.m.
Hi Tapani,

On Mon, May 27, 2013 at 1:13 AM, Tapani Utriainen <tapani@technexion.com> wrote:
>
> Add support for the Wandboard quad.
>
> Signed-off-by: Tapani Utriainen <tapani@technexion.com>
>
> ---
>  boards.cfg                  | 1 +
>  include/configs/wandboard.h | 2 ++
>  2 files changed, 3 insertions(+)

It looks good.

Could you also add an entry for the quad version into the README file?

Regards,

Fabio Estevam
Otavio Salvador - May 27, 2013, 12:13 p.m.
On Mon, May 27, 2013 at 1:13 AM, Tapani Utriainen <tapani@technexion.com>wrote:

>
> Add support for the Wandboard quad.
>
> Signed-off-by: Tapani Utriainen <tapani@technexion.com>
>
> ---
>  boards.cfg                  | 1 +
>  include/configs/wandboard.h | 2 ++
>  2 files changed, 3 insertions(+)
>
> diff --git a/boards.cfg b/boards.cfg
> index 31483d6..b907409 100644
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -268,6 +268,7 @@ nitrogen6s                   arm         armv7
> nitrogen6x          boundar
>  nitrogen6s1g                 arm         armv7       nitrogen6x
>  boundary       mx6
>  nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s1g.cfg,MX6S,DDR_MB=1024
>  wandboard_dl                arm         armv7       wandboard           -
>              mx6
> wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl.cfg,MX6DL,DDR_MB=1024
>  wandboard_solo              arm         armv7       wandboard           -
>              mx6
> wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s.cfg,MX6S,DDR_MB=512
> +wandboard_quad              arm         armv7       wandboard           -
>              mx6
> wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6q2g.cfg,MX6Q,DDR_MB=2048
>

Please put quad, dl and solo in order. It is now dl, solo, quad.


>  cm_t35                       arm         armv7       cm_t35
>  -              omap3
>  omap3_overo                  arm         armv7       overo
> -              omap3
>  omap3_pandora                arm         armv7       pandora
> -              omap3
> diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h
> index 120e3f6..cf22042 100644
> --- a/include/configs/wandboard.h
> +++ b/include/configs/wandboard.h
> @@ -85,6 +85,8 @@
>  #define CONFIG_DEFAULT_FDT_FILE                "imx6dl-wandboard.dtb"
>  #elif defined(CONFIG_MX6S)
>  #define CONFIG_DEFAULT_FDT_FILE                "imx6s-wandboard.dtb"
> +#elif defined(CONFIG_MX6Q)
> +#define CONFIG_DEFAULT_FDT_FILE                "imx6q-wandboard.dtb"
>  #endif
>

Same here.


>  #define CONFIG_EXTRA_ENV_SETTINGS \
> --
> 1.8.0.3
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Otavio Salvador - May 27, 2013, 4:56 p.m.
On Mon, May 27, 2013 at 9:13 AM, Otavio Salvador <otavio@ossystems.com.br>wrote:

> On Mon, May 27, 2013 at 1:13 AM, Tapani Utriainen <tapani@technexion.com>wrote:
>
>>
>> Add support for the Wandboard quad.
>>
>> Signed-off-by: Tapani Utriainen <tapani@technexion.com>
>>
>> ---
>>  boards.cfg                  | 1 +
>>  include/configs/wandboard.h | 2 ++
>>  2 files changed, 3 insertions(+)
>>
>> diff --git a/boards.cfg b/boards.cfg
>> index 31483d6..b907409 100644
>> --- a/boards.cfg
>> +++ b/boards.cfg
>> @@ -268,6 +268,7 @@ nitrogen6s                   arm         armv7
>> nitrogen6x          boundar
>>  nitrogen6s1g                 arm         armv7       nitrogen6x
>>  boundary       mx6
>>  nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s1g.cfg,MX6S,DDR_MB=1024
>>  wandboard_dl                arm         armv7       wandboard
>> -              mx6
>> wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl.cfg,MX6DL,DDR_MB=1024
>>  wandboard_solo              arm         armv7       wandboard
>> -              mx6
>> wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s.cfg,MX6S,DDR_MB=512
>> +wandboard_quad              arm         armv7       wandboard
>> -              mx6
>> wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6q2g.cfg,MX6Q,DDR_MB=2048
>>
>
> Please put quad, dl and solo in order. It is now dl, solo, quad.
>
>
>>  cm_t35                       arm         armv7       cm_t35
>>  -              omap3
>>  omap3_overo                  arm         armv7       overo
>> -              omap3
>>  omap3_pandora                arm         armv7       pandora
>> -              omap3
>> diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h
>> index 120e3f6..cf22042 100644
>> --- a/include/configs/wandboard.h
>> +++ b/include/configs/wandboard.h
>> @@ -85,6 +85,8 @@
>>  #define CONFIG_DEFAULT_FDT_FILE                "imx6dl-wandboard.dtb"
>>  #elif defined(CONFIG_MX6S)
>>  #define CONFIG_DEFAULT_FDT_FILE                "imx6s-wandboard.dtb"
>> +#elif defined(CONFIG_MX6Q)
>> +#define CONFIG_DEFAULT_FDT_FILE                "imx6q-wandboard.dtb"
>>  #endif
>>
>
> Same here.
>
>
>>  #define CONFIG_EXTRA_ENV_SETTINGS \
>>
>
I have sent two patches for adding the Boot Splash with Wandboard logo.
Please take a look on them and if you agree please base on this to avoid
conflicts.

(For easyness: http://patchwork.ozlabs.org/bundle/otavio/wandboard-20130527/
)
Tapani Utriainen - May 28, 2013, 7:44 a.m.
On Mon, 27 May 2013 13:56:30 -0300
Otavio Salvador <otavio@ossystems.com.br> wrote:

> I have sent two patches for adding the Boot Splash with Wandboard logo.
> Please take a look on them and if you agree please base on this to avoid
> conflicts.
> 
> (For easyness: http://patchwork.ozlabs.org/bundle/otavio/wandboard-20130527/
> )
> 

Otavio,

while I do agree with the work you are doing (HDMI bootlogo into mainline),
and would not have minded to base my patches on top of yours.
However, the patches you sent seem to have been NAK:ed. The v3 does not apply 
on top of 2013.04 (maybe I am basing on the wrong release!?).

So for now, I am basing the resubmission on the 2013.04 release.

regards,

//Tapani
Tapani Utriainen - May 28, 2013, 7:45 a.m.
On Mon, 27 May 2013 07:22:42 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> Hi Tapani,
> 
> On Mon, May 27, 2013 at 1:13 AM, Tapani Utriainen <tapani@technexion.com> wrote:
> >
> > Add support for the Wandboard quad.
> >
> > Signed-off-by: Tapani Utriainen <tapani@technexion.com>
> >
> > ---
> >  boards.cfg                  | 1 +
> >  include/configs/wandboard.h | 2 ++
> >  2 files changed, 3 insertions(+)
> 
> It looks good.
> 
> Could you also add an entry for the quad version into the README file?
> 
> Regards,
> 
> Fabio Estevam

Fabio,

thank you, will do (resubmitting a v2). 

//Tapani
Stefano Babic - May 28, 2013, 8:51 a.m.
On 28/05/2013 09:44, Tapani Utriainen wrote:

Hi Tapani,

> Otavio,
> 
> while I do agree with the work you are doing (HDMI bootlogo into mainline),
> and would not have minded to base my patches on top of yours.
> However, the patches you sent seem to have been NAK:ed. The v3 does not apply 
> on top of 2013.04 (maybe I am basing on the wrong release!?).
> 
> So for now, I am basing the resubmission on the 2013.04 release.
> 
> regards,

Even if you are not constrained to take care of underlying patches (this
can maybe discussed in this mailing list if it is strictly required, but
of course it helps to avoid conflicts), it is not correct to stick with
a release. Basis for development is TOT on git.denx.de/u-boot.git, or,
for the i.MXes, git.denx.de/u-boot-imx.

Best regards,
Stefano Babic
Otavio Salvador - May 28, 2013, 12:24 p.m.
On Tue, May 28, 2013 at 4:44 AM, Tapani Utriainen <tapani@technexion.com>wrote:

> On Mon, 27 May 2013 13:56:30 -0300
> Otavio Salvador <otavio@ossystems.com.br> wrote:
>
> > I have sent two patches for adding the Boot Splash with Wandboard logo.
> > Please take a look on them and if you agree please base on this to avoid
> > conflicts.
> >
> > (For easyness:
> http://patchwork.ozlabs.org/bundle/otavio/wandboard-20130527/
> > )
> >
>
> Otavio,
>
> while I do agree with the work you are doing (HDMI bootlogo into mainline),
> and would not have minded to base my patches on top of yours.
> However, the patches you sent seem to have been NAK:ed. The v3 does not
> apply
> on top of 2013.04 (maybe I am basing on the wrong release!?).
>
> So for now, I am basing the resubmission on the 2013.04 release.
>

You must base on imx/master as this is the custodian tree for upcoming
2013.07 release.

Patch

diff --git a/boards.cfg b/boards.cfg
index 31483d6..b907409 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -268,6 +268,7 @@  nitrogen6s                   arm         armv7       nitrogen6x          boundar
 nitrogen6s1g                 arm         armv7       nitrogen6x          boundary       mx6            nitrogen6x:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s1g.cfg,MX6S,DDR_MB=1024
 wandboard_dl                arm         armv7       wandboard           -              mx6 wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6dl.cfg,MX6DL,DDR_MB=1024
 wandboard_solo              arm         armv7       wandboard           -              mx6 wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6s.cfg,MX6S,DDR_MB=512
+wandboard_quad              arm         armv7       wandboard           -              mx6 wandboard:IMX_CONFIG=board/boundary/nitrogen6x/nitrogen6q2g.cfg,MX6Q,DDR_MB=2048
 cm_t35                       arm         armv7       cm_t35              -              omap3
 omap3_overo                  arm         armv7       overo               -              omap3
 omap3_pandora                arm         armv7       pandora             -              omap3
diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h
index 120e3f6..cf22042 100644
--- a/include/configs/wandboard.h
+++ b/include/configs/wandboard.h
@@ -85,6 +85,8 @@ 
 #define CONFIG_DEFAULT_FDT_FILE                "imx6dl-wandboard.dtb"
 #elif defined(CONFIG_MX6S)
 #define CONFIG_DEFAULT_FDT_FILE                "imx6s-wandboard.dtb"
+#elif defined(CONFIG_MX6Q)
+#define CONFIG_DEFAULT_FDT_FILE                "imx6q-wandboard.dtb"
 #endif
 
 #define CONFIG_EXTRA_ENV_SETTINGS \