Patchwork powerpc/pmi: irq handlers return irqreturn_t

mail settings
Submitter Stephen Rothwell
Date March 19, 2009, 3:08 a.m.
Message ID <>
Download mbox | patch
Permalink /patch/24635/
State Accepted, archived
Commit fb2474491cd3925e6ecece0823f4673af3b0d597
Delegated to: Benjamin Herrenschmidt
Headers show


Stephen Rothwell - March 19, 2009, 3:08 a.m.
Commit bedd30d986a05e32dc3eab874e4b9ed8a38058bb ("genirq: make irqreturn_t
an enum") from the genirq tree in next-20090319 caused this new warning:

arch/powerpc/sysdev/pmi.c: In function 'pmi_of_probe':
arch/powerpc/sysdev/pmi.c:166: warning: passing argument 2 of 'request_irq' from incompatible pointer type

Change the return type of the handler from "int" to "irqreturn_t".

Cc: Thomas Gleixner <>
Cc: Peter Zijlstra <>
Signed-off-by: Stephen Rothwell <>
 arch/powerpc/sysdev/pmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/arch/powerpc/sysdev/pmi.c b/arch/powerpc/sysdev/pmi.c
index c858749..aaa9159 100644
--- a/arch/powerpc/sysdev/pmi.c
+++ b/arch/powerpc/sysdev/pmi.c
@@ -50,7 +50,7 @@  struct pmi_data {
 static struct pmi_data *data;
-static int pmi_irq_handler(int irq, void *dev_id)
+static irqreturn_t pmi_irq_handler(int irq, void *dev_id)
 	u8 type;
 	int rc;