Patchwork [committed] PR 55777: inlining nomips16 into mips16

login
register
mail settings
Submitter Richard Sandiford
Date May 25, 2013, 3:52 p.m.
Message ID <87mwrjjbud.fsf@talisman.default>
Download mbox | patch
Permalink /patch/246346/
State New
Headers show

Comments

Richard Sandiford - May 25, 2013, 3:52 p.m.
This patch prevents inlining between functions of different ISA modes.

Tested on mips64-linux-gnu and applied.

Richard


gcc/
	PR target/55777
	* config/mips/mips.c (mips_can_inline_p): New function.
	(TARGET_CAN_INLINE_P): Define.

gcc/testsuite/
	PR target/55777
	* gcc.target/mips/mips16-attributes-5.c,
	* gcc.target/mips/mips16-attributes-6.c: New tests.

Patch

Index: gcc/config/mips/mips.c
===================================================================
--- gcc/config/mips/mips.c	2013-05-21 19:20:41.821261620 +0100
+++ gcc/config/mips/mips.c	2013-05-25 09:35:42.073502492 +0100
@@ -1426,6 +1426,16 @@  mips_merge_decl_attributes (tree olddecl
   return merge_attributes (DECL_ATTRIBUTES (olddecl),
 			   DECL_ATTRIBUTES (newdecl));
 }
+
+/* Implement TARGET_CAN_INLINE_P.  */
+
+static bool
+mips_can_inline_p (tree caller, tree callee)
+{
+  if (mips_get_compress_mode (callee) != mips_get_compress_mode (caller))
+    return false;
+  return default_target_can_inline_p (caller, callee);
+}
 
 /* If X is a PLUS of a CONST_INT, return the two terms in *BASE_PTR
    and *OFFSET_PTR.  Return X in *BASE_PTR and 0 in *OFFSET_PTR otherwise.  */
@@ -18600,6 +18610,8 @@  #define TARGET_FUNCTION_OK_FOR_SIBCALL m
 #define TARGET_INSERT_ATTRIBUTES mips_insert_attributes
 #undef TARGET_MERGE_DECL_ATTRIBUTES
 #define TARGET_MERGE_DECL_ATTRIBUTES mips_merge_decl_attributes
+#undef TARGET_CAN_INLINE_P
+#define TARGET_CAN_INLINE_P mips_can_inline_p
 #undef TARGET_SET_CURRENT_FUNCTION
 #define TARGET_SET_CURRENT_FUNCTION mips_set_current_function
 
Index: gcc/testsuite/gcc.target/mips/mips16-attributes-5.c
===================================================================
--- /dev/null	2013-05-20 18:02:16.162117076 +0100
+++ gcc/testsuite/gcc.target/mips/mips16-attributes-5.c	2013-05-25 09:44:44.576251467 +0100
@@ -0,0 +1,22 @@ 
+/* { dg-do compile } */
+/* { dg-options "(-mips16) addressing=absolute" } */
+/* { dg-skip-if "requires inlining" { *-*-* } { "-O0" } { "" } } */
+
+static inline MIPS16 int i1 (void) { return 1; }
+static inline NOMIPS16 int i2 (void) { return 2; }
+static inline MIPS16 int i3 (void) { return 3; }
+static inline NOMIPS16 int i4 (void) { return 4; }
+
+int NOMIPS16 f1 (void) { return i1 (); }
+int MIPS16 f2 (void) { return i2 (); }
+int MIPS16 f3 (void) { return i3 (); }
+int NOMIPS16 f4 (void) { return i4 (); }
+
+/* { dg-final { scan-assembler "i1:" } } */
+/* { dg-final { scan-assembler "i2:" } } */
+/* { dg-final { scan-assembler-not "i3:" } } */
+/* { dg-final { scan-assembler-not "i4:" } } */
+/* { dg-final { scan-assembler "\tjal\ti1" } } */
+/* { dg-final { scan-assembler "\tjal\ti2" } } */
+/* { dg-final { scan-assembler-not "\tjal\ti3" } } */
+/* { dg-final { scan-assembler-not "\tjal\ti4" } } */
Index: gcc/testsuite/gcc.target/mips/mips16-attributes-6.c
===================================================================
--- /dev/null	2013-05-20 18:02:16.162117076 +0100
+++ gcc/testsuite/gcc.target/mips/mips16-attributes-6.c	2013-05-25 09:50:55.531807654 +0100
@@ -0,0 +1,13 @@ 
+/* { dg-do compile } */
+/* { dg-options "-mips16 addressing=absolute -mips3d" } */
+
+static inline NOMIPS16 float
+i1 (float f)
+{
+  return __builtin_mips_recip1_s (f);
+}
+
+float f1 (float f) { return i1 (f); }
+
+/* { dg-final { scan-assembler "\trecip1.s\t" } } */
+/* { dg-final { scan-assembler "\tjal\ti1" } } */