From patchwork Sat May 25 11:36:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hao X-Patchwork-Id: 246325 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 31CF62C0182 for ; Sat, 25 May 2013 21:37:05 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754719Ab3EYLhD (ORCPT ); Sat, 25 May 2013 07:37:03 -0400 Received: from mail.windriver.com ([147.11.1.11]:36616 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754881Ab3EYLhD (ORCPT ); Sat, 25 May 2013 07:37:03 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.3) with ESMTP id r4PBb1Ue006201 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Sat, 25 May 2013 04:37:01 -0700 (PDT) Received: from pek-khao-d1.corp.ad.wrs.com (128.224.162.196) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.342.3; Sat, 25 May 2013 04:37:01 -0700 From: Kevin Hao To: Bjorn Helgaas CC: Subject: [PATCH 1/3] PCI: add 0x prefix when printing the BAR registers position in __pci_read_base Date: Sat, 25 May 2013 19:36:25 +0800 Message-ID: <1369481787-21500-2-git-send-email-haokexin@gmail.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1369481787-21500-1-git-send-email-haokexin@gmail.com> References: <1369481787-21500-1-git-send-email-haokexin@gmail.com> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org We print the BAR registers position in hexadecimal format, so it is more readable if 0x prefix is added. Also fix the following checkpatch warning: WARNING: Prefer dev_dbg(... to dev_printk(KERN_DEBUG, ... Signed-off-by: Kevin Hao --- v2: A new patch introduced in v2. drivers/pci/probe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 70f10fa..2505d5e 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -278,9 +278,9 @@ out: pci_write_config_word(dev, PCI_COMMAND, orig_cmd); if (bar_too_big) - dev_err(&dev->dev, "reg %x: can't handle 64-bit BAR\n", pos); + dev_err(&dev->dev, "reg 0x%x: can't handle 64-bit BAR\n", pos); if (res->flags && !bar_disabled) - dev_printk(KERN_DEBUG, &dev->dev, "reg %x: %pR\n", pos, res); + dev_dbg(&dev->dev, "reg 0x%x: %pR\n", pos, res); return (res->flags & IORESOURCE_MEM_64) ? 1 : 0; }