From patchwork Fri May 24 17:02:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 246205 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EA2F12C00AB for ; Sat, 25 May 2013 03:03:54 +1000 (EST) Received: from localhost ([::1]:49208 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfvPF-0001jS-1E for incoming@patchwork.ozlabs.org; Fri, 24 May 2013 13:03:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfvOj-0001bZ-D7 for qemu-devel@nongnu.org; Fri, 24 May 2013 13:03:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfvOe-0000xq-L6 for qemu-devel@nongnu.org; Fri, 24 May 2013 13:03:21 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:34367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfvOe-0000xh-EG for qemu-devel@nongnu.org; Fri, 24 May 2013 13:03:16 -0400 Received: by mail-ee0-f53.google.com with SMTP id c1so2726593eek.12 for ; Fri, 24 May 2013 10:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; bh=S5XOSdB2uFPwNL2CLgM1t2RkrsH56rV5SulPbfnXB+A=; b=iMetCJH8XtFJRkqYNPMVd5boHyYL0+I+SQr1DvDbBHN9vgi4S3++c0+2fwXsMlrcmi dmg+E/ycXznqp2ajc0oc2tsH3HYt9tXyHiHJjc43VWFIepDygdObk/fU8OxCmObsBfzP 9h4bdIEesBoUeNZ22Q6n89iengtwToUI7uiW0YUsAOIJz3PCQge2EKXZvvrD++xqaU3F YyMzDaYERjE1V60JIXhIaC5fhy3ur2k9MvPJpPkLAs4+7KkKzVFHv68x8fpnnuZD73ku vaYyKVk66TiXRvwzHFbPRoufDkOE7ywlKjH9+wfyqIa9peZ720RnS3F/tSPSA9qEowgB H0KA== X-Received: by 10.14.204.132 with SMTP id h4mr571147eeo.50.1369414995681; Fri, 24 May 2013 10:03:15 -0700 (PDT) Received: from playground.lan (net-37-117-138-128.cust.dsl.vodafone.it. [37.117.138.128]) by mx.google.com with ESMTPSA id z52sm24872219eea.1.2013.05.24.10.03.13 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 24 May 2013 10:03:14 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 24 May 2013 19:02:53 +0200 Message-Id: <1369414987-8839-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1369414987-8839-1-git-send-email-pbonzini@redhat.com> References: <1369414987-8839-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.83.53 Subject: [Qemu-devel] [PATCH 01/15] exec: remove obsolete comment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org See how we call memory_region_section_addr two lines below to convert a physical address to a base address in the region. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- exec.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/exec.c b/exec.c index aec65c5..197625c 100644 --- a/exec.c +++ b/exec.c @@ -639,12 +639,6 @@ hwaddr memory_region_section_get_iotlb(CPUArchState *env, iotlb |= phys_section_rom; } } else { - /* IO handlers are currently passed a physical address. - It would be nice to pass an offset from the base address - of that region. This would avoid having to special case RAM, - and avoid full address decoding in every device. - We can't use the high bits of pd for this because - IO_MEM_ROMD uses these as a ram address. */ iotlb = section - phys_sections; iotlb += memory_region_section_addr(section, paddr); }