diff mbox

[PATCHv3,1/6] net: Add EMAC ethernet driver found on Allwinner A10 SoC's

Message ID 519F6128.9060608@elopez.com.ar
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Emilio López May 24, 2013, 12:46 p.m. UTC 
El 24/05/13 06:23, Maxime Ripard escribió:
> From: Stefan Roese <sr@denx.de>
> 
> The Allwinner A10 has an ethernet controller that seem to be developped
> internally by them.
> 
> The exact feature set of this controller is unknown, since there is no
> public documentation for this IP, and this driver is mostly the one
> published by Allwinner that has been heavily cleaned up.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

(snip)

> +
> +config SUN4I_EMAC
> +        tristate "Allwinner A10 EMAC support"
> +	depends on ARCH_SUNXI
> +	depends on OF
> +	select CRC32
> +	select NET_CORE
> +	select MII
> +	select REGULATOR_FIXED_VOLTAGE
> +        ---help---
> +          Support for Allwinner A10 EMAC ethernet driver.
> +
> +          To compile this driver as a module, choose M here.  The module
> +          will be called sun4i-emac.
> +

You also need to select REGULATOR when you select REGULATOR_FIXED_VOLTAGE

I have attached a fixup patch you can use with git autosquash

Cheers,

Emilio

Comments

Maxime Ripard May 24, 2013, 8:10 p.m. UTC | #1 
Hi Emilio,

On Fri, May 24, 2013 at 09:46:32AM -0300, Emilio López wrote:
> El 24/05/13 06:23, Maxime Ripard escribió:
> > From: Stefan Roese <sr@denx.de>
> > 
> > The Allwinner A10 has an ethernet controller that seem to be developped
> > internally by them.
> > 
> > The exact feature set of this controller is unknown, since there is no
> > public documentation for this IP, and this driver is mostly the one
> > published by Allwinner that has been heavily cleaned up.
> > 
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> 
> (snip)
> 
> > +
> > +config SUN4I_EMAC
> > +        tristate "Allwinner A10 EMAC support"
> > +	depends on ARCH_SUNXI
> > +	depends on OF
> > +	select CRC32
> > +	select NET_CORE
> > +	select MII
> > +	select REGULATOR_FIXED_VOLTAGE
> > +        ---help---
> > +          Support for Allwinner A10 EMAC ethernet driver.
> > +
> > +          To compile this driver as a module, choose M here.  The module
> > +          will be called sun4i-emac.
> > +
> 
> You also need to select REGULATOR when you select REGULATOR_FIXED_VOLTAGE

Actually, this should be in patch 2/6.

Thanks for noticing!

Maxime
diff mbox

Patch

From f1b94482b4975ce1f7bc542208718f26d5dfa140 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Emilio=20L=C3=B3pez?= <emilio@elopez.com.ar>
Date: Fri, 17 May 2013 10:11:16 -0300
Subject: [PATCH] fixup! net: Add EMAC ethernet driver found on Allwinner A10
 SoC's

---
 drivers/net/ethernet/allwinner/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/allwinner/Kconfig b/drivers/net/ethernet/allwinner/Kconfig
index 7bbd500..47ecbe0 100644
--- a/drivers/net/ethernet/allwinner/Kconfig
+++ b/drivers/net/ethernet/allwinner/Kconfig
@@ -26,6 +26,7 @@  config SUN4I_EMAC
 	select CRC32
 	select NET_CORE
 	select MII
+	select REGULATOR
 	select REGULATOR_FIXED_VOLTAGE
 	select PHYLIB
         ---help---
-- 
1.8.1.6