Patchwork add generic/286 to the auto and quick groups

login
register
mail settings
Submitter Theodore Ts'o
Date May 24, 2013, 4:33 a.m.
Message ID <1369369981-7035-1-git-send-email-tytso@mit.edu>
Download mbox | patch
Permalink /patch/246053/
State Not Applicable
Headers show

Comments

Theodore Ts'o - May 24, 2013, 4:33 a.m.
The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
fast.  We should just run the test by default.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 tests/generic/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Eric Sandeen - May 24, 2013, 4:54 a.m.
On 5/23/13 11:33 PM, Theodore Ts'o wrote:
> The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
> fast.  We should just run the test by default.
> 
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

Seems fine to me

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

another patch to follow to fix it on kernels that don't support it.

> ---
>  tests/generic/group | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/group b/tests/generic/group
> index e2ef70e..bd443c1 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -103,7 +103,7 @@
>  277 auto ioctl quick metadata
>  280 auto quota freeze dangerous
>  285 auto rw
> -286 other
> +286 auto quick other
>  288 auto quick ioctl trim
>  294 auto quick
>  299 auto aio enospc rw stress
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rich Johnston - May 28, 2013, 4:05 p.m.
On 05/23/2013 11:33 PM, Theodore Ts'o wrote:
> The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
> fast.  We should just run the test by default.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> ---
>   tests/generic/group | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index e2ef70e..bd443c1 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -103,7 +103,7 @@
>   277 auto ioctl quick metadata
>   280 auto quota freeze dangerous
>   285 auto rw
> -286 other
> +286 auto quick other
>   288 auto quick ioctl trim
>   294 auto quick
>   299 auto aio enospc rw stress
>
Thanks, this patch has been committed:

commit f45c6881577221e04f6cfe19d25e571bee088996
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Tue May 28 11:01:01 2013 -0500

     xfstests: add generic/286 to the auto and quick groups

--Rich

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/tests/generic/group b/tests/generic/group
index e2ef70e..bd443c1 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -103,7 +103,7 @@ 
 277 auto ioctl quick metadata
 280 auto quota freeze dangerous
 285 auto rw
-286 other
+286 auto quick other
 288 auto quick ioctl trim
 294 auto quick
 299 auto aio enospc rw stress