Patchwork [U-Boot,V3,1/4] README: document CONFIG_ENV_IS_IN_MMC

login
register
mail settings
Submitter Stephen Warren
Date May 23, 2013, 8:51 p.m.
Message ID <1369342307-21983-1-git-send-email-swarren@wwwdotorg.org>
Download mbox | patch
Permalink /patch/246026/
State Superseded, archived
Delegated to: Andy Fleming
Headers show

Comments

Stephen Warren - May 23, 2013, 8:51 p.m.
From: Stephen Warren <swarren@nvidia.com>

Describe the meaning of CONFIG_ENV_IS_IN_MMC, and all related defines that
must or can be set when using that option.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
v3:
* Mention that env size/offset are in bytes.
* Fix typo; s/CONFIG_ENV_OFFSET/CONFIG_ENV_SIZE/ in one place.
v2: New patch.
---
 README |   40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
Peter Korsgaard - May 23, 2013, 9:59 p.m.
>>>>> "S" == Stephen Warren <swarren@wwwdotorg.org> writes:

 S> From: Stephen Warren <swarren@nvidia.com>
 S> Describe the meaning of CONFIG_ENV_IS_IN_MMC, and all related defines that
 S> must or can be set when using that option.

 S> Signed-off-by: Stephen Warren <swarren@nvidia.com>
 S> ---
 S> v3:
 S> * Mention that env size/offset are in bytes.
 S> * Fix typo; s/CONFIG_ENV_OFFSET/CONFIG_ENV_SIZE/ in one place.
 S> v2: New patch.
 S> ---
 S>  README |   40 ++++++++++++++++++++++++++++++++++++++++
 S>  1 file changed, 40 insertions(+)

 S> diff --git a/README b/README
 S> index 3012dcd..e7fedb8 100644
 S> --- a/README
 S> +++ b/README
 S> @@ -3606,6 +3606,46 @@ but it can not erase, write this NOR flash by SRIO or PCIE interface.
 S>  	  You will probably want to define these to avoid a really noisy system
 S>  	  when storing the env in UBI.
 
 S> +- CONFIG_ENV_IS_IN_MMC:
 S> +
 S> +	Define this if you have an MMC device which you want to use for the
 S> +	environment.
 S> +
 S> +	- CONFIG_SYS_MMC_ENV_DEV:
 S> +
 S> +	  Specifies which MMC device the environment is stored in.
 S> +
 S> +	- CONFIG_SYS_MMC_ENV_PART (optional):
 S> +
 S> +	  Specifies which MMC partition the environment is stored in. If not
 S> +	  set, defaults to partition 0, the user area. Common values might be
 S> +	  1 (first MMC boot partition), 2 (second MMC boot partition).
 S> +
 S> +	- CONFIG_ENV_OFFSET:
 S> +	- CONFIG_ENV_SIZE:
 S> +
 S> +	  These two #defines specify the offset and size of the environment
 S> +	  area within the specified MMC device.
 S> +
 S> +	  These two values are in units of bytes, but must be aligned to an
 S> +	  MMC sector boundary.

s/to an/t a/

Other than that:

Reviewed-by: Peter Korsgaard <jacmet@sunsite.dk>
Stephen Warren - May 23, 2013, 10:15 p.m.
On 05/23/2013 03:59 PM, Peter Korsgaard wrote:
>>>>>> "S" == Stephen Warren <swarren@wwwdotorg.org> writes:
> 
...
>  S> +	  These two values are in units of bytes, but must be aligned to an
>  S> +	  MMC sector boundary.
> 
> s/to an/to a/

http://owl.english.purdue.edu/owl/resource/540/1/ disagrees since the M
starts with a vowel sound. See the "An MSDS ..." example.

Either way though is fine by me though I guess.

I assume Tom can fix that up when applying, so I don't need to spam the
list with another resend.
Peter Korsgaard - May 23, 2013, 10:32 p.m.
>>>>> "Stephen" == Stephen Warren <swarren@wwwdotorg.org> writes:

 Stephen> On 05/23/2013 03:59 PM, Peter Korsgaard wrote:
 >>>>>>> "S" == Stephen Warren <swarren@wwwdotorg.org> writes:
 >> 
 Stephen> ...
 S> +	  These two values are in units of bytes, but must be aligned to an
 S> +	  MMC sector boundary.
 >> 
 >> s/to an/to a/

 Stephen> http://owl.english.purdue.edu/owl/resource/540/1/ disagrees
 Stephen> since the M starts with a vowel sound. See the "An MSDS ..."
 Stephen> example.

Ok, I'm not a native speaker.
Tom Rini - May 24, 2013, 3:24 p.m.
On Thu, May 23, 2013 at 02:51:44PM -0600, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> Describe the meaning of CONFIG_ENV_IS_IN_MMC, and all related defines that
> must or can be set when using that option.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Acked-by: Tom Rini <trini@ti.com>
Stephen Warren - May 24, 2013, 3:47 p.m.
On 05/24/2013 09:24 AM, Tom Rini wrote:
> On Thu, May 23, 2013 at 02:51:44PM -0600, Stephen Warren wrote:
> 
>> From: Stephen Warren <swarren@nvidia.com>
>> 
>> Describe the meaning of CONFIG_ENV_IS_IN_MMC, and all related
>> defines that must or can be set when using that option.
>> 
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> 
> Acked-by: Tom Rini <trini@ti.com>

TomR, I assume you want Andy Fleming to take this series through the
MMC tree?

TomW, if patch 4/4 is OK with you, can you ack it so that someone else
can take it, or do you want them to apply patches 1-3, wait until you
can pick them up in the Tegra tree, and then apply patch 4 yourself?
Tom Rini - May 24, 2013, 3:51 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/24/2013 11:47 AM, Stephen Warren wrote:
> On 05/24/2013 09:24 AM, Tom Rini wrote:
>> On Thu, May 23, 2013 at 02:51:44PM -0600, Stephen Warren wrote:
>> 
>>> From: Stephen Warren <swarren@nvidia.com>
>>> 
>>> Describe the meaning of CONFIG_ENV_IS_IN_MMC, and all related 
>>> defines that must or can be set when using that option.
>>> 
>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> 
>> Acked-by: Tom Rini <trini@ti.com>
> 
> TomR, I assume you want Andy Fleming to take this series through
> the MMC tree?
> 
> TomW, if patch 4/4 is OK with you, can you ack it so that someone
> else can take it, or do you want them to apply patches 1-3, wait
> until you can pick them up in the Tegra tree, and then apply patch
> 4 yourself?

Correct, and I've given these to Andy in patchwork as well.  Thanks!

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRn4x8AAoJENk4IS6UOR1WjnQP/3wZXbkkM+EzxbQXQUV2n5gY
aQa5qUAKrZHJ5YyNhjuewoZV0zzSkPYeb3BXeKKGJWc7mZ1ZEBb9ffqBrY88LVa+
BnFEGLDjM7pHRuuDk4nLsXdMhP18O0kJC3QyNh5Js4b3AH3WwMs8tvAyH854+Zh0
xAXx04y6flMyL+ZiaNA1v95I0U52hxqOsUazGqP7Cm0poHahIMN3WdiHefcebLRb
vsyGr1cVdGjAl4vc7fGmeWqwvKTKE/9a/usDujf0eVmVjkpNioT9FYmiGZC3SlEV
bI1YpgNkNSEjj2DlkiCUIly0JHaUX3KgDypEmPS4i/qGAk6EpLlmalZrcZD1+Md+
xZ+aaIQVg6d9ixzBJ0RraXLdil6Gkp3DkwQdz0IjdBBmxWaTelN1iCSwmmaYl544
MXaZ8ptF7qubKMvqYYQ7IqOV9eZ18UQ5vhrQ4OLmLDQPhoi+3Hzq/7X9gXn1c4t9
SB6+B4G6LqtCebSAzhwTVLL5SaA0SbJC8fyFSb1e/SaTeal3+0DGQAUKLN7+XNoo
B+uXLXGdzQuI3I0kF+z9l4MLD2vO/4sOu7ib9KsV2Z3Hz+Onfs+Oq/2QsYinzClT
C3lMMCgzoJCSv3K9UcaOj2z6KHQFy76Xq1eUhMmh0Arg/th4vzFXfboJpXTzwqv7
TxT5m9kyPEjOONVGPLDe
=Eoa+
-----END PGP SIGNATURE-----
Stephen Warren - June 4, 2013, 7:31 p.m.
On 05/23/2013 02:51 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Describe the meaning of CONFIG_ENV_IS_IN_MMC, and all related defines that
> must or can be set when using that option.

Andy, do you intend to take these patches for the upcoming release, or
defer them until the next one? Thanks.
Andy Fleming - June 4, 2013, 8:39 p.m.
I'll take them. It's on my todo list for this week

On Jun 4, 2013, at 14:31, "Stephen Warren" <swarren@wwwdotorg.org> wrote:

> On 05/23/2013 02:51 PM, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>> 
>> Describe the meaning of CONFIG_ENV_IS_IN_MMC, and all related defines that
>> must or can be set when using that option.
> 
> Andy, do you intend to take these patches for the upcoming release, or
> defer them until the next one? Thanks.
>

Patch

diff --git a/README b/README
index 3012dcd..e7fedb8 100644
--- a/README
+++ b/README
@@ -3606,6 +3606,46 @@  but it can not erase, write this NOR flash by SRIO or PCIE interface.
 	  You will probably want to define these to avoid a really noisy system
 	  when storing the env in UBI.
 
+- CONFIG_ENV_IS_IN_MMC:
+
+	Define this if you have an MMC device which you want to use for the
+	environment.
+
+	- CONFIG_SYS_MMC_ENV_DEV:
+
+	  Specifies which MMC device the environment is stored in.
+
+	- CONFIG_SYS_MMC_ENV_PART (optional):
+
+	  Specifies which MMC partition the environment is stored in. If not
+	  set, defaults to partition 0, the user area. Common values might be
+	  1 (first MMC boot partition), 2 (second MMC boot partition).
+
+	- CONFIG_ENV_OFFSET:
+	- CONFIG_ENV_SIZE:
+
+	  These two #defines specify the offset and size of the environment
+	  area within the specified MMC device.
+
+	  These two values are in units of bytes, but must be aligned to an
+	  MMC sector boundary.
+
+	- CONFIG_ENV_OFFSET_REDUND (optional):
+
+	  Specifies a second storage area, of CONFIG_ENV_SIZE size, used to
+	  hold a redundant copy of the environment data. This provides a
+	  valid backup copy in case the other copy is corrupted, e.g. due
+	  to a power failure during a "saveenv" operation.
+
+	  This value is also in units of bytes, but must also be aligned to
+	  an MMC sector boundary.
+
+	- CONFIG_ENV_SIZE_REDUND (optional):
+
+	  This value need not be set, even when CONFIG_ENV_OFFSET_REDUND is
+	  set. If this value is set, it must be set to the same value as
+	  CONFIG_ENV_SIZE.
+
 - CONFIG_SYS_SPI_INIT_OFFSET
 
 	Defines offset to the initial SPI buffer area in DPRAM. The