| Message ID | 1369328974.3123.77.camel@Thor |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
Ummm, no. You don't export every single function just because it appears in a header file. When we have an in-kernel module that needs these functions, we can export them, but no sooner. So until you submit a set of changes that use these routines from modules we're not exporting them. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index af9185d..0976908 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -1854,6 +1854,7 @@ done: return ret; } +EXPORT_SYMBOL(skb_splice_bits); /** * skb_store_bits - store bits from kernel buffer to skb
skb_splice_bits() is already available in include/linux/skbuff.h, but without EXPORT_SYMBOL it can't be used by kernel modules. Signed-off-by: Michel Machado <michel@digirati.com.br> CC: "David S. Miller" <davem@davemloft.net> CC: Eric Dumazet <edumazet@google.com> CC: Pravin B Shelar <pshelar@nicira.com> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html