Patchwork [RFC,v3,3/3] i2c: pxa: use module_platform_driver() replace init/exit

login
register
mail settings
Submitter Libo Chen
Date May 23, 2013, noon
Message ID <1369310411-35652-1-git-send-email-libo.chen@huawei.com>
Download mbox | patch
Permalink /patch/245927/
State Rejected
Headers show

Comments

Libo Chen - May 23, 2013, noon
use module_platform_driver() macro to replace the module init/exit

Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
 drivers/i2c/busses/i2c-pxa.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)
chenlibo.3@gmail.com - May 23, 2013, 1:48 p.m.
maybe I make a mistake, please drop it.

于 2013-5-23 20:00, Libo Chen 写道:
> use module_platform_driver() macro to replace the module init/exit
> 
> Signed-off-by: Libo Chen<libo.chen@huawei.com>
> ---
>   drivers/i2c/busses/i2c-pxa.c |   10 +---------
>   1 files changed, 1 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
> index 7b10102..e9c3524 100644
> --- a/drivers/i2c/busses/i2c-pxa.c
> +++ b/drivers/i2c/busses/i2c-pxa.c
> @@ -1242,15 +1242,7 @@ static struct platform_driver i2c_pxa_driver = {
>   	.id_table	= i2c_pxa_id_table,
>   };
>   
> -static int __init i2c_adap_pxa_init(void)
> -{
> -	return platform_driver_register(&i2c_pxa_driver);
> -}
> -
> -static void __exit i2c_adap_pxa_exit(void)
> -{
> -	platform_driver_unregister(&i2c_pxa_driver);
> -}
> +module_platform_driver(i2c_pxa_driver);
>   
>   MODULE_LICENSE("GPL");
>   MODULE_ALIAS("platform:pxa2xx-i2c");

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wolfram Sang - June 12, 2013, 10:03 a.m.
On Thu, May 23, 2013 at 09:48:22PM +0800, Libo Chen wrote:
> maybe I make a mistake, please drop it.

Which mistake?
Wolfram Sang - June 12, 2013, 10:05 a.m.
On Wed, Jun 12, 2013 at 12:03:13PM +0200, Wolfram Sang wrote:
> On Thu, May 23, 2013 at 09:48:22PM +0800, Libo Chen wrote:
> > maybe I make a mistake, please drop it.
> 
> Which mistake?

Wrong window, now I see it.

Patch

diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 7b10102..e9c3524 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -1242,15 +1242,7 @@  static struct platform_driver i2c_pxa_driver = {
 	.id_table	= i2c_pxa_id_table,
 };
 
-static int __init i2c_adap_pxa_init(void)
-{
-	return platform_driver_register(&i2c_pxa_driver);
-}
-
-static void __exit i2c_adap_pxa_exit(void)
-{
-	platform_driver_unregister(&i2c_pxa_driver);
-}
+module_platform_driver(i2c_pxa_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:pxa2xx-i2c");