| Message ID | 1369307473-20696-2-git-send-email-f.fainelli@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2013-05-23 at 12:11 +0100, Florian Fainelli wrote: > Add a comment which explains the real meaning of XCVR_INTERNAL (PHY and > Ethernet MAC in the same package/die) and XCVR_EXTERNAL (PHY and > Ethernet MAC in a different package/die). Most if not all of the drivers > setting their transceiver type already do it the way the comment > describes it. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> I had another look over the drivers that use both values, and I think there aren't any remaining exceptions to the definition you're giving. Sorry for holding this up. Reviewed-by: Ben Hutchings <bhutchings@solarflare.com> Ben. > --- > include/uapi/linux/ethtool.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > index 0c9b448..38dbafa 100644 > --- a/include/uapi/linux/ethtool.h > +++ b/include/uapi/linux/ethtool.h > @@ -993,8 +993,8 @@ enum ethtool_sfeatures_retval_bits { > #define PORT_OTHER 0xff > > /* Which transceiver to use. */ > -#define XCVR_INTERNAL 0x00 > -#define XCVR_EXTERNAL 0x01 > +#define XCVR_INTERNAL 0x00 /* PHY and MAC are in the same package */ > +#define XCVR_EXTERNAL 0x01 /* PHY and MAC are in different packages */ > #define XCVR_DUMMY1 0x02 > #define XCVR_DUMMY2 0x03 > #define XCVR_DUMMY3 0x04
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 0c9b448..38dbafa 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -993,8 +993,8 @@ enum ethtool_sfeatures_retval_bits { #define PORT_OTHER 0xff /* Which transceiver to use. */ -#define XCVR_INTERNAL 0x00 -#define XCVR_EXTERNAL 0x01 +#define XCVR_INTERNAL 0x00 /* PHY and MAC are in the same package */ +#define XCVR_EXTERNAL 0x01 /* PHY and MAC are in different packages */ #define XCVR_DUMMY1 0x02 #define XCVR_DUMMY2 0x03 #define XCVR_DUMMY3 0x04
Add a comment which explains the real meaning of XCVR_INTERNAL (PHY and Ethernet MAC in the same package/die) and XCVR_EXTERNAL (PHY and Ethernet MAC in a different package/die). Most if not all of the drivers setting their transceiver type already do it the way the comment describes it. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- include/uapi/linux/ethtool.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)