Patchwork [33/33] drivers/rtc/rtc-wm831x.c: remove empty function

login
register
mail settings
Submitter Sachin Kamat
Date May 23, 2013, 10:36 a.m.
Message ID <1369305374-20433-33-git-send-email-sachin.kamat@linaro.org>
Download mbox | patch
Permalink /patch/245915/
State New
Headers show

Comments

Sachin Kamat - May 23, 2013, 10:36 a.m.
After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/rtc/rtc-wm831x.c |    6 ------
 1 file changed, 6 deletions(-)
Mark Brown - May 27, 2013, 11:28 a.m.
On Thu, May 23, 2013 at 04:06:14PM +0530, Sachin Kamat wrote:
> After the switch to devm_* functions and the removal of
> rtc_device_unregister(), the 'remove' function does not do anything.
> Delete it.

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Patch

diff --git a/drivers/rtc/rtc-wm831x.c b/drivers/rtc/rtc-wm831x.c
index 8d65b94..75aea4c 100644
--- a/drivers/rtc/rtc-wm831x.c
+++ b/drivers/rtc/rtc-wm831x.c
@@ -460,11 +460,6 @@  err:
 	return ret;
 }
 
-static int wm831x_rtc_remove(struct platform_device *pdev)
-{
-	return 0;
-}
-
 static const struct dev_pm_ops wm831x_rtc_pm_ops = {
 	.suspend = wm831x_rtc_suspend,
 	.resume = wm831x_rtc_resume,
@@ -478,7 +473,6 @@  static const struct dev_pm_ops wm831x_rtc_pm_ops = {
 
 static struct platform_driver wm831x_rtc_driver = {
 	.probe = wm831x_rtc_probe,
-	.remove = wm831x_rtc_remove,
 	.driver = {
 		.name = "wm831x-rtc",
 		.pm = &wm831x_rtc_pm_ops,