Patchwork [23/33] drivers/rtc/rtc-ps3.c: remove empty function

login
register
mail settings
Submitter Sachin Kamat
Date May 23, 2013, 10:36 a.m.
Message ID <1369305374-20433-23-git-send-email-sachin.kamat@linaro.org>
Download mbox | patch
Permalink /patch/245905/
State New
Headers show

Comments

Sachin Kamat - May 23, 2013, 10:36 a.m.
After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Geoff Levand <geoff@infradead.org>
---
 drivers/rtc/rtc-ps3.c |    6 ------
 1 file changed, 6 deletions(-)
Geoff Levand - May 24, 2013, 9:37 p.m.
On Thu, 2013-05-23 at 16:06 +0530, Sachin Kamat wrote:
> After the switch to devm_* functions and the removal of
> rtc_device_unregister(), the 'remove' function does not do anything.
> Delete it.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Geoff Levand <geoff@infradead.org>
> ---
>  drivers/rtc/rtc-ps3.c |    6 ------
>  1 file changed, 6 deletions(-)

Looks OK, thanks.

Acked-by: Geoff Levand <geoff@infradead.org>

Patch

diff --git a/drivers/rtc/rtc-ps3.c b/drivers/rtc/rtc-ps3.c
index 4bb825b..554ada5 100644
--- a/drivers/rtc/rtc-ps3.c
+++ b/drivers/rtc/rtc-ps3.c
@@ -71,17 +71,11 @@  static int __init ps3_rtc_probe(struct platform_device *dev)
 	return 0;
 }
 
-static int __exit ps3_rtc_remove(struct platform_device *dev)
-{
-	return 0;
-}
-
 static struct platform_driver ps3_rtc_driver = {
 	.driver = {
 		.name = "rtc-ps3",
 		.owner = THIS_MODULE,
 	},
-	.remove = __exit_p(ps3_rtc_remove),
 };
 
 module_platform_driver_probe(ps3_rtc_driver, ps3_rtc_probe);