Patchwork [10/33] drivers/rtc/rtc-generic.c: remove empty function

login
register
mail settings
Submitter Sachin Kamat
Date May 23, 2013, 10:35 a.m.
Message ID <1369305374-20433-10-git-send-email-sachin.kamat@linaro.org>
Download mbox | patch
Permalink /patch/245891/
State New
Headers show

Comments

Sachin Kamat - May 23, 2013, 10:35 a.m.
After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>
---
 drivers/rtc/rtc-generic.c |    6 ------
 1 file changed, 6 deletions(-)
Kyle McMartin - May 23, 2013, 2:31 p.m.
On Thu, May 23, 2013 at 04:05:51PM +0530, Sachin Kamat wrote:
> After the switch to devm_* functions and the removal of
> rtc_device_unregister(), the 'remove' function does not do anything.
> Delete it.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Kyle McMartin <kyle@mcmartin.ca>

looks good to me.

Patch

diff --git a/drivers/rtc/rtc-generic.c b/drivers/rtc/rtc-generic.c
index 06279ce..9b6725e 100644
--- a/drivers/rtc/rtc-generic.c
+++ b/drivers/rtc/rtc-generic.c
@@ -48,17 +48,11 @@  static int __init generic_rtc_probe(struct platform_device *dev)
 	return 0;
 }
 
-static int __exit generic_rtc_remove(struct platform_device *dev)
-{
-	return 0;
-}
-
 static struct platform_driver generic_rtc_driver = {
 	.driver = {
 		.name = "rtc-generic",
 		.owner = THIS_MODULE,
 	},
-	.remove = __exit_p(generic_rtc_remove),
 };
 
 module_platform_driver_probe(generic_rtc_driver, generic_rtc_probe);