[RESEND] mtd: mtdchar: Exit write loop when hitting end of OTP memory

Submitted by Christian Riesch on May 23, 2013, 9:56 a.m.


Message ID 924bb94e-8254-46b8-8942-2d5de8ab2985@mary.at.omicron.at
State Superseded
Headers show

Commit Message

Christian Riesch May 23, 2013, 9:56 a.m.
If a write to one time programmable memory (OTP) hits the end
of this memory area, no more data can be written and count does not
decrease anymore. We are trapped in the loop forever.

Therefore drop the remaining data if retlen != len.

Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
 drivers/mtd/mtdchar.c |    4 ++++
 1 file changed, 4 insertions(+)

Patch hide | download patch | download mbox

diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index e0e59bf..70c18c2 100644
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
@@ -321,6 +321,10 @@  static ssize_t mtdchar_write(struct file *file, const char __user *buf, size_t c
 			ret = mtd_write_user_prot_reg(mtd, *ppos, len,
 						      &retlen, kbuf);
+			/* if we hit the end of otp memory, drop the rest */
+			if (retlen != len)
+				count -= len - retlen;