Patchwork [v4,1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON

login
register
mail settings
Submitter liguang
Date May 23, 2013, 6:58 a.m.
Message ID <1369292323-31762-1-git-send-email-lig.fnst@cn.fujitsu.com>
Download mbox | patch
Permalink /patch/245825/
State New
Headers show

Comments

liguang - May 23, 2013, 6:58 a.m.
when use DEBUG_DEBUGCON, screen spits:
debugcon: write addr=0x0000 val=0x00
Rdebugcon: write addr=0x0000 val=0x00
udebugcon: write addr=0x0000 val=0x00
ndebugcon: write addr=0x0000 val=0x00
ndebugcon: write addr=0x0000 val=0x00
idebugcon: write addr=0x0000 val=0x00
ndebugcon: write addr=0x0000 val=0x00
gdebugcon: write addr=0x0000 val=0x00
 debugcon: write addr=0x0000 val=0x00
odebugcon: write addr=0x0000 val=0x00
pdebugcon: write addr=0x0000 val=0x00
tdebugcon: write addr=0x0000 val=0x00
idebugcon: write addr=0x0000 val=0x00
odebugcon: write addr=0x0000 val=0x00
ndebugcon: write addr=0x0000 val=0x00
 debugcon: write addr=0x0000 val=0x00
rdebugcon: write addr=0x0000 val=0x00
odebugcon: write addr=0x0000 val=0x00
mdebugcon: write addr=0x0000 val=0x00
 debugcon: write addr=0x0000 val=0x00
adebugcon: write addr=0x0000 val=0x00
tdebugcon: write addr=0x0000 val=0x00
 debugcon: write addr=0x0000 val=0x00

Oh, that's wrong, val is not always be 0.
this bug caused by lack of length modifier
for specifier 'x'.

Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
v4: fix misleading subject
---
 hw/char/debugcon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Andreas Färber - May 23, 2013, 1:05 p.m.
Am 23.05.2013 08:58, schrieb liguang:
> when use DEBUG_DEBUGCON, screen spits:
> debugcon: write addr=0x0000 val=0x00
> Rdebugcon: write addr=0x0000 val=0x00
> udebugcon: write addr=0x0000 val=0x00
> ndebugcon: write addr=0x0000 val=0x00
> ndebugcon: write addr=0x0000 val=0x00
> idebugcon: write addr=0x0000 val=0x00
> ndebugcon: write addr=0x0000 val=0x00
> gdebugcon: write addr=0x0000 val=0x00
>  debugcon: write addr=0x0000 val=0x00
> odebugcon: write addr=0x0000 val=0x00
> pdebugcon: write addr=0x0000 val=0x00
> tdebugcon: write addr=0x0000 val=0x00
> idebugcon: write addr=0x0000 val=0x00
> odebugcon: write addr=0x0000 val=0x00
> ndebugcon: write addr=0x0000 val=0x00
>  debugcon: write addr=0x0000 val=0x00
> rdebugcon: write addr=0x0000 val=0x00
> odebugcon: write addr=0x0000 val=0x00
> mdebugcon: write addr=0x0000 val=0x00
>  debugcon: write addr=0x0000 val=0x00
> adebugcon: write addr=0x0000 val=0x00
> tdebugcon: write addr=0x0000 val=0x00
>  debugcon: write addr=0x0000 val=0x00
> 
> Oh, that's wrong, val is not always be 0.
> this bug caused by lack of length modifier
> for specifier 'x'.
> 
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
> v4: fix misleading subject

As I've reminded before, please prepend a cover letter (0/x) when
sending more than once patch!

> ---
>  hw/char/debugcon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
> index 02c9577..7e41c90 100644
> --- a/hw/char/debugcon.c
> +++ b/hw/char/debugcon.c
> @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val,
>      unsigned char ch = val;
>  
>  #ifdef DEBUG_DEBUGCON
> -    printf("debugcon: write addr=0x%04x val=0x%02x\n", addr, val);
> +    printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);

Please merge 3/3 with this patch - the changes are pretty obviously
correct, so you can shorten the commit message by dropping the example
output.

Andreas

>  #endif
>  
>      qemu_chr_fe_write(s->chr, &ch, 1);
>
liguang - May 24, 2013, 12:20 a.m.
在 2013-05-23四的 15:05 +0200,Andreas Färber写道:
> Am 23.05.2013 08:58, schrieb liguang:
> > when use DEBUG_DEBUGCON, screen spits:
> > debugcon: write addr=0x0000 val=0x00
> > Rdebugcon: write addr=0x0000 val=0x00
> > udebugcon: write addr=0x0000 val=0x00
> > ndebugcon: write addr=0x0000 val=0x00
> > ndebugcon: write addr=0x0000 val=0x00
> > idebugcon: write addr=0x0000 val=0x00
> > ndebugcon: write addr=0x0000 val=0x00
> > gdebugcon: write addr=0x0000 val=0x00
> >  debugcon: write addr=0x0000 val=0x00
> > odebugcon: write addr=0x0000 val=0x00
> > pdebugcon: write addr=0x0000 val=0x00
> > tdebugcon: write addr=0x0000 val=0x00
> > idebugcon: write addr=0x0000 val=0x00
> > odebugcon: write addr=0x0000 val=0x00
> > ndebugcon: write addr=0x0000 val=0x00
> >  debugcon: write addr=0x0000 val=0x00
> > rdebugcon: write addr=0x0000 val=0x00
> > odebugcon: write addr=0x0000 val=0x00
> > mdebugcon: write addr=0x0000 val=0x00
> >  debugcon: write addr=0x0000 val=0x00
> > adebugcon: write addr=0x0000 val=0x00
> > tdebugcon: write addr=0x0000 val=0x00
> >  debugcon: write addr=0x0000 val=0x00
> > 
> > Oh, that's wrong, val is not always be 0.
> > this bug caused by lack of length modifier
> > for specifier 'x'.
> > 
> > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> > ---
> > v4: fix misleading subject
> 
> As I've reminded before, please prepend a cover letter (0/x) when
> sending more than once patch!

OK, I'll write cover-letter.
I thought since they are trivial patch, you'll not mind 
that I sent without cover-letter before.

Thanks!

> 
> > ---
> >  hw/char/debugcon.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
> > index 02c9577..7e41c90 100644
> > --- a/hw/char/debugcon.c
> > +++ b/hw/char/debugcon.c
> > @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val,
> >      unsigned char ch = val;
> >  
> >  #ifdef DEBUG_DEBUGCON
> > -    printf("debugcon: write addr=0x%04x val=0x%02x\n", addr, val);
> > +    printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);
> 
> Please merge 3/3 with this patch - the changes are pretty obviously
> correct, so you can shorten the commit message by dropping the example
> output.
> 
> Andreas
> 
> >  #endif
> >  
> >      qemu_chr_fe_write(s->chr, &ch, 1);
> > 
> 
>

Patch

diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
index 02c9577..7e41c90 100644
--- a/hw/char/debugcon.c
+++ b/hw/char/debugcon.c
@@ -55,7 +55,7 @@  static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val,
     unsigned char ch = val;
 
 #ifdef DEBUG_DEBUGCON
-    printf("debugcon: write addr=0x%04x val=0x%02x\n", addr, val);
+    printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);
 #endif
 
     qemu_chr_fe_write(s->chr, &ch, 1);